Merged
Conversation
Remove or replace panics with error logs, replace XXX & TODO comments with more elaborate normal comments. Signed-off-by: Jarno Rajahalme <[email protected]>
Bump tier for egress default allow rule like we do for default ingress allow. Bump is only done if non-zero tier or priority is used in the policy. Signed-off-by: Jarno Rajahalme <[email protected]>
Make 'ruleSlice.resolveL4Policy()' easier to read by factoring out 'ruleSlice.computeTierPriorities()' as a separate function. Suggested-by: Blaz Zupan <[email protected]> Signed-off-by: Jarno Rajahalme <[email protected]>
Add test case with default allow to make sure default allow mapstate entry is properly created. Add "derived from" labels to the default allow rules to separate them from explicit allow-all rules. Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
added
kind/enhancement
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
jrajahalme
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
2 tasks
jrajahalme
requested review from
TheBeeZee and
squeed
and removed request for
tklauser
Member
Author
|
Assigned @squeed and @TheBeeZee as reviewers as this PR addresses their comments at #42896. |
Member
Author
|
/test |
squeed
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the remaining comments at #42896 that did not get to the initial merge:
Fixes: #42896