Skip to content

v1.18 Backports: envoy: Allow customize per cluster connections / requests limit#43455

Closed
exherb wants to merge 1 commit intocilium:v1.18from
adtalos:v1.18
Closed

v1.18 Backports: envoy: Allow customize per cluster connections / requests limit#43455
exherb wants to merge 1 commit intocilium:v1.18from
adtalos:v1.18

Conversation

@exherb
Copy link
Copy Markdown
Contributor

@exherb exherb commented Dec 20, 2025 •
edited
Loading

[x] upstream pr #43049

@exherb exherb requested a review from a team as a code owner December 20, 2025 13:06
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Dec 20, 2025
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper bot commented Dec 20, 2025

Commit 8cb77c1 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 20, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Dec 20, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 20, 2025
@exherb exherb mentioned this pull request Dec 22, 2025
Merged
8 tasks
@julianwiedmann julianwiedmann added the dont-merge/discussion A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status. label Dec 22, 2025
@julianwiedmann
Copy link
Copy Markdown
Member

julianwiedmann commented Dec 22, 2025

Note that we typically don't backport features / enhancements to stable releases. The exact criteria are spelled out here.

mhofstetter
mhofstetter requested changes Dec 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport commit isn't "identical" to the upstream commit.

Backport criteria: The changes don't match the backport criterias - even though i would understand a backport in this case because the hardcoded value is quite random and could be seen as bug/missconfiguration. On the other hand we're close to the v1.19 release anyway. But I leave the final decision to the committers.

Backport proposal: @exherb We typically discuss and propose PR backports on the upstream PR itself (incl. adding needs-backport/vxx). Backporter rotation will then pick up the labelled PRs and open the backport PRs. Manual backport PRs by the author are only necessary if the backport has too many conflicts on older release branch.

@exherb exherb closed this Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhofstetter mhofstetter mhofstetter requested changes

@gandro gandro Awaiting requested review from gandro

Assignees

No one assigned

Labels

backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. dont-merge/discussion A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status. kind/backports This PR provides functionality previously merged into master. kind/community-contribution This was a contribution made by a community member.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@exherb @julianwiedmann @mhofstetter