Skip to content

Revert "multi-pool: add support for excluding IP pools from masquerade"#43379

Merged
gandro merged 1 commit intomainfrom
revert-40132-addsnatexclusion
Dec 16, 2025
Merged

Revert "multi-pool: add support for excluding IP pools from masquerade"#43379
gandro merged 1 commit intomainfrom
revert-40132-addsnatexclusion

Conversation

@gandro
Copy link
Copy Markdown
Member

@gandro gandro commented Dec 16, 2025

Reverts #40132

Unfortunately, the PR introduced a common CI flake: #40132 (comment)

cc @cilium/maintainers can we merge this without a review from all code owners?
cc @alimehrabikoshki

@gandro gandro requested review from a team as code owners December 16, 2025 16:10
@gandro gandro added the release-note/misc This PR makes changes that have no direct user impact. label Dec 16, 2025
@gandro gandro requested review from a team as code owners December 16, 2025 16:10
@gandro gandro added the area/multipool Affects Multi-Pool IPAM label Dec 16, 2025
@gandro gandro requested a review from youngnick December 16, 2025 16:10
@maintainer-s-little-helper

This comment was marked as resolved.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 16, 2025
@gandro gandro force-pushed the revert-40132-addsnatexclusion branch from 7eff411 to 57bd97d Compare December 16, 2025 16:11
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 16, 2025
@gandro
Copy link
Copy Markdown
Member Author

gandro commented Dec 16, 2025

/test

@gandro
Copy link
Copy Markdown
Member Author

gandro commented Dec 16, 2025

Relevant CI is green. Force-merging to unblock CI.

@gandro gandro merged commit 365c110 into main Dec 16, 2025
330 of 345 checks passed
@gandro gandro deleted the revert-40132-addsnatexclusion branch December 16, 2025 16:51
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/multipool Affects Multi-Pool IPAM release-note/misc This PR makes changes that have no direct user impact.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

2 participants