Skip to content

endpoint/veth-cleanup: move endpoint veth iface cleanup into endpoint restorer#43373

Merged
aanm merged 2 commits intocilium:mainfrom
mhofstetter:pr/mhofstetter/endpoint-veth-cleanup
Dec 18, 2025
Merged

endpoint/veth-cleanup: move endpoint veth iface cleanup into endpoint restorer#43373
aanm merged 2 commits intocilium:mainfrom
mhofstetter:pr/mhofstetter/endpoint-veth-cleanup

Conversation

@mhofstetter
Copy link
Copy Markdown
Member

@mhofstetter mhofstetter commented Dec 16, 2025

Currently, cleaning up stale cilium veth devices is handled
by the legacy daemon initialization logic.

This commit moves this logic into the endpoint restorer where
the cleanup is executed as hive lifecycle start hook before any endpoint
is restored.

@mhofstetter mhofstetter added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. area/modularization Relates to code modularization and maintenance. labels Dec 16, 2025
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/endpoint-veth-cleanup branch 3 times, most recently from 8967d17 to 86fe8fb Compare December 16, 2025 16:09
@mhofstetter
Copy link
Copy Markdown
Member Author

mhofstetter commented Dec 16, 2025

/test

ci-multi-pool hit known issue. fixed with revert #43379

@mhofstetter mhofstetter marked this pull request as ready for review December 16, 2025 16:47
@mhofstetter mhofstetter requested review from a team as code owners December 16, 2025 16:47
Copy link
Copy Markdown
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack for CODEOWNERS change

This commit simplifies the logic that cleans up stale endpoint veth devices.
Mainly removing the unnecessary functionality to provide a filter function
when listing the veth devices.

Signed-off-by: Marco Hofstetter <[email protected]>
Currently, cleaning up stale cilium veth devices is handled
by the legacy daemon initialization logic.

This commit moves this logic into the endpoint restorer where
the cleanup is executed as hive lifecycle start hook.

Signed-off-by: Marco Hofstetter <[email protected]>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/endpoint-veth-cleanup branch from 86fe8fb to 5f70867 Compare December 17, 2025 09:09
@mhofstetter
Copy link
Copy Markdown
Member Author

rebased to main to resolve conflicts

@mhofstetter
Copy link
Copy Markdown
Member Author

mhofstetter commented Dec 17, 2025

/test

Facing Timeout waiting for response to forwarded proxied DNS lookup two times (different workflows) - already reported here

@aanm aanm added this pull request to the merge queue Dec 18, 2025
Merged via the queue into cilium:main with commit 044344d Dec 18, 2025
77 of 78 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/endpoint-veth-cleanup branch December 18, 2025 08:01
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/modularization Relates to code modularization and maintenance. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

7 participants