Merged
Conversation
julianwiedmann
added
area/datapath
julianwiedmann
force-pushed
the
pr/jwi/main/bpf-lb-cleanup
branch
from
3e23d0d to
5a50a22
Compare
Member
Author
|
/test |
julianwiedmann
force-pushed
the
pr/jwi/main/bpf-lb-cleanup
branch
from
5a50a22 to
1935860
Compare
Member
Author
|
/test |
While these helpers are related to LB state, they are really managing how bpf_lxc's per-packet path is propagating its internal state across a program-internal tailcall. So let's maintain them closer to where they are being used, there is no shared logic here. Also add a bit of build test coverage for the per-packet LB. Signed-off-by: Julian Wiedmann <[email protected]>
Instead of passing a full ct_state struct, we can just pass a simple flag to indicate whether the service request is of loopback type. From the N/S path we can now always pass `false`, and optimize the relevant code out. Signed-off-by: Julian Wiedmann <[email protected]>
Now that the callers have access to the selected backend, they can just take fetch the backend's cluster_id themselves. Signed-off-by: Julian Wiedmann <[email protected]>
All usage has essentially moved to lb*_dnat_request() now, and for the IPv6 function we were already relying on the __maybe_unused to suppress the compile error. Signed-off-by: Julian Wiedmann <[email protected]>
julianwiedmann
force-pushed
the
pr/jwi/main/bpf-lb-cleanup
branch
from
1935860 to
646cec4
Compare
Member
Author
|
/test |
gentoo-root
reviewed
Nov 27, 2025
gentoo-root
approved these changes
Nov 27, 2025
ti-mo
approved these changes
Nov 27, 2025
maintainer-s-little-helper
bot
added
the
ready-to-merge
nezdolik
pushed a commit
to nezdolik/cilium
that referenced
this pull request
Jan 14, 2026
- `go mod tidy && go mod vendor && go mod verify` - `cd enterprise/hubble-timescape && go mod tidy && cd ../..` - fixed minor conflicts in `bpf/bpf_lxc.c`, `bpf/bpf_overlay.c` and `bpf/lib/nodeport.h` so that both new OSS code and previous Enterprise includes are present - fixed conflicts in `pkg/datapath/config/host_config.go`, `pkg/datapath/config/lxc_config.go` and `pkg/datapath/config/overlay_config.go` - adapted `enterprise/pkg/maps/extepspolicy/table.go`, `enterprise/pkg/fqdnha/relay/namemanager.go` and `enterprise/pkg/maps/extepspolicy/writer_test.go` due to function signature changes in OSS - `git cherry-pick -n 3d4abeb61b72d910c58ddb199b189c86c4eaf326 71023768865b9085e6aa8991c553997e1cc6f9b8` to pick up patches from @rastislavs (+ manual added fix in `enterprise/pkg/bgpv1/manager/reconcilerv2/neighbor_test.go` based on patch changes) - `make -C images update-builder-image update-runtime-image` - `make -C Documentation update-cmdref` - `./contrib/scripts/enterprise-testowners.sh` - remove duplicate `Cleanup Disk space in runner` step in `.github/workflows/cilium-cli.yaml` - fix mindfulness issues by manually fixing stuff coming from the following PRs: - [cilium#42169](cilium#42169) - [cilium#42011](cilium#42011) - [cilium#42012](cilium#42012) - `make generate-enterprise-apis` ~- adjusted `enterprise/pkg/ingresspolicy` after commit 2faed3a ("policy: fix selector policy leak and detachment issues") removed the implicit addition of the identity on lookup. Now the identity needs to be added and removed in the identity manager.~ Split into separate PR isovalent/cilium#9506 to ease review and backporting. - Set `clustermesh.config.enabled=true` in enterprise-clustermesh-overlapping-podcidr workflow following commit 562ba2c ("clustermesh: set authMode to migration by default"). - Had to revert the following commits because they break the ILB CI workflow. Thanks to @mhofstetter for bisecting! See discussion for more details. Upstream fix and re-applying the changes is tracked in isovalent/cilium#9511. - cilium#42986 - 6781758 - 3cfe7a1 - a8fd4ed - 64e171e - cilium#42973 - c171f22 (with minor conflict resolution) - 9530af5 - not necessary to revert the last 2 commit of that PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few minor follow-up cleanups for #42973.