ci: Enable modernize golangci-lint linter#42642
Merged
Conversation
Ranging over SplitSeq is more efficient Signed-off-by: Hadrien Patte <[email protected]>
HasPrefix + TrimPrefix can be simplified to CutPrefix Signed-off-by: Hadrien Patte <[email protected]>
reflect.TypeOf call can be simplified using TypeFor Signed-off-by: Hadrien Patte <[email protected]>
interface{} can be replaced by any
Signed-off-by: Hadrien Patte <[email protected]>
if statement can be modernized using min Signed-off-by: Hadrien Patte <[email protected]>
Signed-off-by: Hadrien Patte <[email protected]>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
HadrienPatte
changed the title
modernize golangci-lint linter
github-actions
bot
added
the
sig/policy
HadrienPatte
requested review from
YutaroHayakawa,
bimmlerd,
brlbil,
derailed,
fristonio,
pippolo84,
rolinh and
youngnick
fristonio
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
derailed
approved these changes
Nov 6, 2025
Contributor
derailed
left a comment
derailed
left a comment
There was a problem hiding this comment.
@HadrienPatte Nice work!
bimmlerd
approved these changes
Nov 7, 2025
Member
|
/test |
pippolo84
approved these changes
Nov 7, 2025
brlbil
approved these changes
Nov 7, 2025
youngnick
approved these changes
Nov 10, 2025
rolinh
approved these changes
Nov 10, 2025
YutaroHayakawa
approved these changes
Nov 10, 2025
maintainer-s-little-helper
bot
added
ready-to-merge
HadrienPatte
added a commit
that referenced
this pull request
Dec 10, 2025
This PR addresses [`rangeint`](https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/modernize#hdr-Analyzer_rangeint) findings in datapath owned files in preparation to enabling this analyzer repository-wide (see [here](https://github.com/cilium/cilium/blob/888c09ae6be6034d5c8a362659b7fd082f6b6a1b/.golangci.yaml#L119-L123)). See #42642 Signed-off-by: Hadrien Patte <[email protected]>
HadrienPatte
added a commit
that referenced
this pull request
Dec 10, 2025
This PR addresses [`rangeint`](https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/modernize#hdr-Analyzer_rangeint) findings in datapath owned files in preparation to enabling this analyzer repository-wide (see [here](https://github.com/cilium/cilium/blob/888c09ae6be6034d5c8a362659b7fd082f6b6a1b/.golangci.yaml#L119-L123)). See #42642 Signed-off-by: Hadrien Patte <[email protected]>
harsimran-pabla
pushed a commit
to harsimran-pabla/cilium
that referenced
this pull request
Dec 11, 2025
This PR addresses [`rangeint`](https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/modernize#hdr-Analyzer_rangeint) findings in datapath owned files in preparation to enabling this analyzer repository-wide (see [here](https://github.com/cilium/cilium/blob/888c09ae6be6034d5c8a362659b7fd082f6b6a1b/.golangci.yaml#L119-L123)). See cilium#42642 Signed-off-by: Hadrien Patte <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #42525
This PR enables the new
modernizegolangci-lint linter that's available since golangci-lint 2.6.0 (#42514).This PR includes fixes for the following
modernizeanalyzers that would currently be failing:stringsseq: Ranging over SplitSeq is more efficientstringscutprefix: HasPrefix + TrimPrefix can be simplified to CutPrefixreflecttypefor: reflect.TypeOf call can be simplified using TypeForany: interface{} can be replaced by anyminmax: if statement can be modernized using minThe following
modernizeanalyzers are currently disabled as fixing them would cause a larger diff and should be done in separate PRs:omitzerorangeintstringsbuilderwaitgroup