Skip to content

policy: Remove support for FromRequires and ToRequires#42615

Merged
tklauser merged 1 commit intocilium:mainfrom
TheBeeZee:pr-remove-requires
Nov 7, 2025
Merged

policy: Remove support for FromRequires and ToRequires#42615
tklauser merged 1 commit intocilium:mainfrom
TheBeeZee:pr-remove-requires

Conversation

@TheBeeZee
Copy link
Copy Markdown
Contributor

@TheBeeZee TheBeeZee commented Nov 6, 2025

FromRequires / ToRequires has been deprecated since 1.17.

Support for FromRequires and ToRequires in Cilium Network Policies has been removed.

@TheBeeZee TheBeeZee requested review from a team as code owners November 6, 2025 00:00
@TheBeeZee TheBeeZee requested a review from squeed November 6, 2025 00:00
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 6, 2025
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label Nov 6, 2025
@TheBeeZee
Copy link
Copy Markdown
Contributor Author

/test

Copy link
Copy Markdown
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀 Lets also update the corresponding documentation.
Changes looks good apart from a minor nit.

@tklauser tklauser added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Nov 6, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 6, 2025
Copy link
Copy Markdown
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an entry to the 1.19 upgrade notes in the documentation about the removal of these fields.

Also, I think this note in policy language documentation can now be removed:

.. warning::
The ``fromRequires`` and ``toRequires`` fields are deprecated as of Cilium
1.17.x. They will be dropped from support in Cilium 1.18.

Copy link
Copy Markdown
Contributor

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the upgrading document is updated, LGTM.

@TheBeeZee TheBeeZee requested a review from a team as a code owner November 6, 2025 16:36
@TheBeeZee TheBeeZee requested a review from qmonnet November 6, 2025 16:36
@TheBeeZee TheBeeZee force-pushed the pr-remove-requires branch 2 times, most recently from 9ca3ad7 to 373d4d4 Compare November 6, 2025 16:39
Copy link
Copy Markdown
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes look good, thank you!

@qmonnet qmonnet requested a review from tklauser November 6, 2025 17:04
@jrajahalme
Copy link
Copy Markdown
Member

/test

@tklauser tklauser enabled auto-merge November 7, 2025 09:28
@tklauser tklauser added this pull request to the merge queue Nov 7, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 7, 2025
Merged via the queue into cilium:main with commit c98e572 Nov 7, 2025
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

6 participants