Skip to content

cilium-cli: convert net.IP to netip.Addr#42371

Merged
aanm merged 1 commit intocilium:mainfrom
phuhung273:cilium-cli-netip
Dec 22, 2025
Merged

cilium-cli: convert net.IP to netip.Addr#42371
aanm merged 1 commit intocilium:mainfrom
phuhung273:cilium-cli-netip

Conversation

@phuhung273
Copy link
Copy Markdown
Contributor

@phuhung273 phuhung273 commented Oct 24, 2025

cilium-cli convert net.IP to netip.Addr. With some nil check skipped because there is already a nil check in earlier step. Eg:

cilium/cilium-cli/connectivity/tests/egressgateway.go

Lines 159 to 167 in d44238a

egressGatewayNodeInternalIP := ct.GetGatewayNodeInternalIP(egressGatewayNode, false)
if egressGatewayNodeInternalIP == nil {
t.Fatal("Cannot get IPv4 egress gateway node internal IP")
}
egressGatewayNodeInternalIPv6 := ct.GetGatewayNodeInternalIP(egressGatewayNode, true)
if ipv6Enabled && egressGatewayNodeInternalIPv6 == nil {
t.Fatal("Cannot get IPv6 egress gateway node internal IP")
}

For #24246

@phuhung273 phuhung273 requested review from a team as code owners October 24, 2025 10:45
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 24, 2025
@phuhung273 phuhung273 requested a review from Artyop October 24, 2025 10:45
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli kind/community-contribution This was a contribution made by a community member. labels Oct 24, 2025
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Oct 30, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 30, 2025
bersoare
bersoare reviewed Nov 19, 2025
View reviewed changes
@bersoare
Copy link
Copy Markdown
Contributor

bersoare commented Nov 19, 2025

/test

@bersoare
Copy link
Copy Markdown
Contributor

bersoare commented Nov 19, 2025

/ci-e2e-upgrade

@bersoare
Copy link
Copy Markdown
Contributor

bersoare commented Nov 19, 2025

looks like we have some egress gateway failures: https://github.com/cilium/cilium/actions/runs/19504507259/job/55827029786

@phuhung273
Copy link
Copy Markdown
Contributor Author

phuhung273 commented Nov 19, 2025

Thanks so much @bersoare. Seems like it actually my change.

@phuhung273
Copy link
Copy Markdown
Contributor Author

phuhung273 commented Nov 21, 2025

Really appreciate your help @bersoare. Please give me some time, I'm trying to provision a LVH kind kernel 6.1/6.12 to reproduce the issue. These things are completely new to me.

@bersoare
Copy link
Copy Markdown
Contributor

bersoare commented Nov 21, 2025

you could try to take a look at the sysdump and see if there are any clues in the logs. you can download it from https://github.com/cilium/cilium/actions/runs/19505589442 , scroll all the way down

@bersoare
Copy link
Copy Markdown
Contributor

bersoare commented Nov 24, 2025

/ci-ipsec-e2e

@phuhung273
Copy link
Copy Markdown
Contributor Author

phuhung273 commented Nov 24, 2025

Thanks so much @bersoare, turn out it was my silly condition check 😅

@bersoare
Copy link
Copy Markdown
Contributor

bersoare commented Nov 24, 2025

/test

@phuhung273
Copy link
Copy Markdown
Contributor Author

phuhung273 commented Nov 24, 2025

I think it makes sense to rerun ci-multi-pool as:

@bersoare
Copy link
Copy Markdown
Contributor

bersoare commented Nov 24, 2025

/ci-multi-pool

youngnick
youngnick approved these changes Dec 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sig-agent changes LGTM.

@aanm aanm enabled auto-merge December 16, 2025 10:16
@aanm
Copy link
Copy Markdown
Member

aanm commented Dec 16, 2025

/test

@aanm
Copy link
Copy Markdown
Member

aanm commented Dec 16, 2025

There's a legitimate failure in CI

101.8 connectivity/check/deployment.go:842:15: undefined: net

@phuhung273
Copy link
Copy Markdown
Contributor Author

phuhung273 commented Dec 16, 2025

We have #42150 merged with the use of net.ParseIp, let me rebase @aanm

auto-merge was automatically disabled December 16, 2025 15:40

Head branch was pushed to by a user without write access

@aanm aanm enabled auto-merge December 16, 2025 16:15
@aanm
Copy link
Copy Markdown
Member

aanm commented Dec 16, 2025

/test

@phuhung273
Copy link
Copy Markdown
Contributor Author

phuhung273 commented Dec 17, 2025

I can see #43373 (comment) reported the same issue: #33144

Could you help me retest @aanm. Thank you for the help.

@aanm aanm added this pull request to the merge queue Dec 22, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 22, 2025
Merged via the queue into cilium:main with commit 85ee93f Dec 22, 2025
75 of 76 checks passed
@phuhung273 phuhung273 deleted the cilium-cli-netip branch December 22, 2025 13:10
zocimek pushed a commit to zocimek/home-ops that referenced this pull request Feb 1, 2026
@zocimek-renovate
feat(deps): update dependency aqua:cilium/cilium-cli ( 0.18.9 ➔ 0.19.…
2cba5fd 
…0 ) (#584)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[aqua:cilium/cilium-cli](https://redirect.github.com/cilium/cilium-cli)
| minor | `0.18.9` → `0.19.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>cilium/cilium-cli (aqua:cilium/cilium-cli)</summary>

###
[`v0.19.0`](https://redirect.github.com/cilium/cilium-cli/releases/tag/v0.19.0)

[Compare
Source](https://redirect.github.com/cilium/cilium-cli/compare/v0.18.9...v0.19.0)

## Summary of Changes

**CI Changes:**

- Add L7 policy traffic disruption tests
([cilium/cilium#42150](https://redirect.github.com/cilium/cilium/issues/42150),
[@&#8203;fristonio](https://redirect.github.com/fristonio))
- Cilium-cli SNI connectivity tests now retry expected successful
operations to recover from failures due to external upstream issues.
([cilium/cilium#42980](https://redirect.github.com/cilium/cilium/issues/42980),
[@&#8203;jrajahalme](https://redirect.github.com/jrajahalme))
- cli: connectivity: fix typo in L7 LB tests
([cilium/cilium#43610](https://redirect.github.com/cilium/cilium/issues/43610),
[@&#8203;julianwiedmann](https://redirect.github.com/julianwiedmann))
- Fix intermittent NodePort connectivity test timeouts in dual-stack
clusters by validating NodePort readiness on all node IP addresses
during test setup.
([cilium/cilium#40812](https://redirect.github.com/cilium/cilium/issues/40812),
[@&#8203;pillai-ashwin](https://redirect.github.com/pillai-ashwin))
- tests: remove identity manager from ignored error messages
([cilium/cilium#42982](https://redirect.github.com/cilium/cilium/issues/42982),
[@&#8203;odinuge](https://redirect.github.com/odinuge))

**Misc Changes:**

- chore(deps): update all-dependencies (main)
([cilium/cilium#43169](https://redirect.github.com/cilium/cilium/issues/43169),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update all-dependencies (main)
([cilium/cilium#43456](https://redirect.github.com/cilium/cilium/issues/43456),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update all-dependencies (main)
([cilium/cilium#43508](https://redirect.github.com/cilium/cilium/issues/43508),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update base-images (main)
([cilium/cilium#43457](https://redirect.github.com/cilium/cilium/issues/43457),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update base-images (main)
([cilium/cilium#43538](https://redirect.github.com/cilium/cilium/issues/43538),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update docker.io/library/golang:1.25.5 docker digest to
[`a22b2e6`](https://redirect.github.com/cilium/cilium-cli/commit/a22b2e6)
(main)
([cilium/cilium#43303](https://redirect.github.com/cilium/cilium/issues/43303),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update go to v1.25.5 (main)
([cilium/cilium#43173](https://redirect.github.com/cilium/cilium/issues/43173),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- cilium-cli/connectivity: remove matcher for bpf/init.sh errors
([cilium/cilium#43109](https://redirect.github.com/cilium/cilium/issues/43109),
[@&#8203;tklauser](https://redirect.github.com/tklauser))
- cilium-cli: convert net.IP to netip.Addr
([cilium/cilium#42371](https://redirect.github.com/cilium/cilium/issues/42371),
[@&#8203;phuhung273](https://redirect.github.com/phuhung273))
- cli: Update `network-perf` image ref
([cilium/cilium#43297](https://redirect.github.com/cilium/cilium/issues/43297),
[@&#8203;HadrienPatte](https://redirect.github.com/HadrienPatte))
- chore(deps): update golangci/golangci-lint-action action to v9.2.0 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3148](https://redirect.github.com/cilium/cilium-cli/pull/3148)
- Update stable release to v0.18.9 by
[@&#8203;michi-covalent](https://redirect.github.com/michi-covalent) in
[#&#8203;3149](https://redirect.github.com/cilium/cilium-cli/pull/3149)
- chore(deps): update golangci/golangci-lint docker tag to v2.7.0 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3151](https://redirect.github.com/cilium/cilium-cli/pull/3151)
- chore(deps): update go to v1.25.5 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3153](https://redirect.github.com/cilium/cilium-cli/pull/3153)
- ci: clean up disk space in release workflow by
[@&#8203;tklauser](https://redirect.github.com/tklauser) in
[#&#8203;3154](https://redirect.github.com/cilium/cilium-cli/pull/3154)
- chore(deps): update actions/stale action to v10.1.1 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3150](https://redirect.github.com/cilium/cilium-cli/pull/3150)
- chore(deps): update gcr.io/distroless/static:latest docker digest to
[`4b2a093`](https://redirect.github.com/cilium/cilium-cli/commit/4b2a093)
by [@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3152](https://redirect.github.com/cilium/cilium-cli/pull/3152)
- chore(deps): update golangci/golangci-lint docker tag to v2.7.2 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3155](https://redirect.github.com/cilium/cilium-cli/pull/3155)
- chore(deps): update docker.io/library/golang:1.25.5 docker digest to
[`a22b2e6`](https://redirect.github.com/cilium/cilium-cli/commit/a22b2e6)
by [@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3156](https://redirect.github.com/cilium/cilium-cli/pull/3156)
- chore(deps): update actions/upload-artifact action to v6 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3157](https://redirect.github.com/cilium/cilium-cli/pull/3157)
- chore(deps): update docker.io/library/golang:1.25.5 docker digest to
[`36b4f45`](https://redirect.github.com/cilium/cilium-cli/commit/36b4f45)
by [@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3160](https://redirect.github.com/cilium/cilium-cli/pull/3160)
- chore(deps): update dependency cilium/cilium to v1.18.5 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3159](https://redirect.github.com/cilium/cilium-cli/pull/3159)
- chore(deps): update dependency kubernetes-sigs/kind to v0.31.0 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3158](https://redirect.github.com/cilium/cilium-cli/pull/3158)
- chore(deps): update docker/setup-buildx-action action to v3.12.0 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3162](https://redirect.github.com/cilium/cilium-cli/pull/3162)
- chore(deps): update golangci/golangci-lint docker tag to v2.8.0 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3163](https://redirect.github.com/cilium/cilium-cli/pull/3163)
- chore(deps): update docker.io/library/golang:1.25.5 docker digest to
[`6cc2338`](https://redirect.github.com/cilium/cilium-cli/commit/6cc2338)
by [@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3164](https://redirect.github.com/cilium/cilium-cli/pull/3164)
- chore(deps): update gcr.io/distroless/static:latest docker digest to
[`cd64bec`](https://redirect.github.com/cilium/cilium-cli/commit/cd64bec)
by [@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3165](https://redirect.github.com/cilium/cilium-cli/pull/3165)
- chore(deps): update actions/setup-go action to v6.2.0 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3166](https://redirect.github.com/cilium/cilium-cli/pull/3166)
- Prepare for v0.19.0 release by
[@&#8203;tklauser](https://redirect.github.com/tklauser) in
[#&#8203;3167](https://redirect.github.com/cilium/cilium-cli/pull/3167)

**Full Changelog**:
<cilium/cilium-cli@v0.18.9...v0.19.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi44MS4yIiwidXBkYXRlZEluVmVyIjoiNDIuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9taW5vciJdfQ==-->

Co-authored-by: zocimek-renovate[bot] <134739422+zocimek-renovate[bot]@users.noreply.github.com>
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ysksuzuki ysksuzuki ysksuzuki approved these changes

@aanm aanm aanm approved these changes

@youngnick youngnick youngnick approved these changes

@Artyop Artyop Artyop approved these changes

+1 more reviewer

@bersoare bersoare bersoare approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cilium-cli This PR contains changes related with cilium-cli kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

No open projects
cilium v1.19.0
Status: Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@phuhung273 @bersoare @aanm @ysksuzuki @youngnick @Artyop @joestringer