k8s: Skip endpoints without conditions#41234
Merged
joamaki merged 1 commit intocilium:mainfrom Aug 18, 2025
Merged
Conversation
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
Contributor
Author
|
/ci-ginkgo |
Contributor
Author
|
/test |
Skip endpoints in endpoint slices that have no conditions set as those are not yet ready to serve traffic. Before this they were marked quarantined which is unnecessary and it caused issues as the quarantined state was restored and not cleared until health checked (and we usually don't have a health checker). Fixes: cilium#41194 Fixes: 6f41c98 ("loadbalancer: Keep non-serving terminating backends") Signed-off-by: Jussi Maki <[email protected]>
joamaki
force-pushed
the
pr/joamaki/lb-ignore-endpoints-without-conditions
branch
from
44e243c to
ddfc499
Compare
Contributor
Author
|
/test |
borkmann
approved these changes
Aug 18, 2025
Member
borkmann
left a comment
borkmann
left a comment
There was a problem hiding this comment.
ack lgtm, I presume this was also the behavior prior to the set of fixes, right?
Contributor
Author
Correct, prior to 6f41c98 we just skipped such backends. |
marseel
reviewed
Aug 18, 2025
marseel
approved these changes
Aug 18, 2025
Member
marseel
left a comment
marseel
left a comment
There was a problem hiding this comment.
from offline discussion: this change (revert) is incorrect as mentioned above from service load balancing point of view, but it unblocks CI for everyone. Approve pending creating issue to track it.
Contributor
Author
|
joamaki
added a commit
to joamaki/cilium
that referenced
this pull request
Oct 14, 2025
To avoid disrupting connections to backends that are flapping on their readiness state, keep the backends in the backends BPF map, but not in the services map. This in effect reverts the temporary workaround in cilium#41234. Fixes: cilium#41244 Signed-off-by: Jussi Maki <[email protected]>
joamaki
added a commit
to joamaki/cilium
that referenced
this pull request
Oct 14, 2025
To avoid disrupting connections to backends that are flapping on their readiness state, keep the backends in the backends BPF map, but not in the services map. This in effect reverts the temporary workaround in cilium#41234. Fixes: cilium#41244 Signed-off-by: Jussi Maki <[email protected]>
joamaki
added a commit
to joamaki/cilium
that referenced
this pull request
Oct 20, 2025
To avoid disrupting connections to backends that are flapping on their readiness state, keep the backends in the backends BPF map, but not in the services map. This in effect reverts the temporary workaround in cilium#41234. Fixes: cilium#41244 Signed-off-by: Jussi Maki <[email protected]>
joamaki
added a commit
to joamaki/cilium
that referenced
this pull request
Oct 27, 2025
To avoid disrupting connections to backends that are flapping on their readiness state, keep the backends in the backends BPF map, but not in the services map. This in effect reverts the temporary workaround in cilium#41234. Fixes: cilium#41244 Signed-off-by: Jussi Maki <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
To avoid disrupting connections to backends that are flapping on their readiness state, keep the backends in the backends BPF map, but not in the services map. This in effect reverts the temporary workaround in #41234. Fixes: #41244 Signed-off-by: Jussi Maki <[email protected]>
joamaki
added a commit
to joamaki/cilium
that referenced
this pull request
Nov 11, 2025
[ upstream commit 73812ed ] To avoid disrupting connections to backends that are flapping on their readiness state, keep the backends in the backends BPF map, but not in the services map. This in effect reverts the temporary workaround in cilium#41234. Fixes: cilium#41244 Signed-off-by: Jussi Maki <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
[ upstream commit 73812ed ] To avoid disrupting connections to backends that are flapping on their readiness state, keep the backends in the backends BPF map, but not in the services map. This in effect reverts the temporary workaround in #41234. Fixes: #41244 Signed-off-by: Jussi Maki <[email protected]>
nddq
pushed a commit
to nddq/cilium
that referenced
this pull request
Feb 17, 2026
[ upstream commit 73812ed ] To avoid disrupting connections to backends that are flapping on their readiness state, keep the backends in the backends BPF map, but not in the services map. This in effect reverts the temporary workaround in cilium#41234. Fixes: cilium#41244 Signed-off-by: Jussi Maki <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip endpoints in endpoint slices that have no conditions set as those are not yet ready to serve traffic. Before this they were marked quarantined which caused issues as the quarantined state was restored and not cleared until health checked (and we usually don't have a health checker).
While we do want to keep unready endpoints around, we'll need to figure out what to mark them as that doesn't have the interaction with health checking. This is thus a temporary fix to go back to the old behavior. Opened issue #41244 to follow up on this.
Fixes: #41194
Fixes: 6f41c98 ("loadbalancer: Keep non-serving terminating backends")