Conversation
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
sig/policy
sayboras
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
sayboras
force-pushed
the
pr/tammach/remove-proxylib
branch
from
3547511 to
cb5517a
Compare
|
/test |
sayboras
force-pushed
the
pr/tammach/remove-proxylib
branch
2 times, most recently
from
2c0303c to
726ae31
Compare
|
/test |
sayboras
force-pushed
the
pr/tammach/remove-proxylib
branch
from
726ae31 to
2ab41c3
Compare
jrajahalme
left a comment
jrajahalme
left a comment
There was a problem hiding this comment.
Looks right, hopefully there is no residual fallout from this!
|
/test |
The libcilium.so file is removed from Docker image, so hopefully we can catch issue if any, at least in embedded mode. IMO, it's better to perform the cleanup in early dev cycle rather than later. |
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
- The Issue link in your commit description is broken, trailing
g:Relates: https://github.com/cilium/cilium/issues/38224g - The proxylib removal probably warrants a mention in the upgrade notes?
qmonnet
added
the
upgrade-impact
|
I don't think we can do this yet. I didn't see any deprecation warning for Kafka policies. Given that an end-user has no idea what proxylib is, but does know what Kafka policies are, we needed to add the warning there. So, I think we can't remove kafka until v1.20. |
squeed
added
the
dont-merge/discussion
|
@jrajahalme observes that the Kafka protocol version we support is very outdated, so it is unlikely to be in use. I'm still not comfortable deprecating something without proper notice, but perhaps this may be an exception. @joestringer, thoughts? |
|
We should go through the standard deprecation cycle. It's a pity we didn't consider this just a few days earlier or we could have included this in the v1.18 release announcement. We'd better deprecate in v1.19 and remove in v1.20. |
|
Thanks all for chime in and highlight the gaps, I should have added the note in v1.18., Agreed that we should delay the removal in 1.20, will send another PR to add deprecation note. |
Relates: #38224 Relates: #40757 (comment) Signed-off-by: Tam Mach <[email protected]>
Relates: #38224 Relates: #40757 (comment) Signed-off-by: Tam Mach <[email protected]>
Relates: #38224 Relates: #40757 (comment) Signed-off-by: Tam Mach <[email protected]>
Relates: #38224 Relates: #40757 (comment) Signed-off-by: Tam Mach <[email protected]>
Relates: cilium#38224 Relates: cilium#40757 (comment) Signed-off-by: Tam Mach <[email protected]>
7 participants
Fixes: #38224