vendor: Update `github.com/google/go-github` to v73 by HadrienPatte · Pull Request #40326 · cilium/cilium

HadrienPatte · 2025-07-02T13:52:55Z

Same as #40104, this is currently making #40325 fail

Also update the renovate config to prevent it from trying to do major upgrades for github.com/google/go-github as those will always require manually updating import paths.

Please ensure your pull request adheres to the following guidelines:

For first time contributors, read Submitting a pull request
All code is covered by unit and/or runtime tests where feasible.
All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
All commits are signed off. See the section Developer’s Certificate of Origin
Provide a title or release-note blurb suitable for the release notes.
Are you a user of Cilium? Please add yourself to the Users doc
Thanks for contributing!

vendor: Update github.com/google/go-github to v73

Same as #40104, this is currently making #40325 fail Signed-off-by: Hadrien Patte <[email protected]>

Signed-off-by: Hadrien Patte <[email protected]>

tklauser · 2025-07-02T14:25:32Z

/test

tklauser

Thank you

joestringer

Thanks 🙏

Major updates were disabled for the `github.com/google/go-github` module in #40326 as renovate was not updating the import paths, which is needed for major updates. It turns out that renovate is able to also update those import paths with the `gomodUpdateImportPaths` `postUpdateOptions` ([ref](https://docs.renovatebot.com/modules/manager/gomod/#major-upgrades-of-dependencies)). This `postUpdateOptions` is supposed to be configured for the [`all-go-deps-main`](https://github.com/cilium/cilium/blob/36dd14d9c3ab8d0806c1f269327e8f6792a10664/.github/renovate.json5#L202-L216) update group, but this actually conflicts with the top level config [here](https://github.com/cilium/cilium/blob/36dd14d9c3ab8d0806c1f269327e8f6792a10664/.github/renovate.json5#L52-L54) that only configures `gomodTidy`. I ran some tests on a test repository and was able to confirm that in order to get `gomodUpdateImportPaths` to work as expected, what we need is to remove the `postUpdateOptions` config from the `all-go-deps-main` group and set `gomodUpdateImportPaths` in the top level `postUpdateOptions` instead of `gomodTidy` (we can remove `gomodTidy` because `gomodUpdateImportPaths` is a superset of it). The only difference will be that for renovate PRs that attempt to do a major go module upgrade, renovate will now also update the import paths (which depending on the dependency may still not be enough). With this PR I also remove the config block that disabled major updates for `go-github` as renovate should now be able to handle these. See #42857 (review) Signed-off-by: Hadrien Patte <[email protected]>

Major updates were disabled for the `github.com/google/go-github` module in cilium#40326 as renovate was not updating the import paths, which is needed for major updates. It turns out that renovate is able to also update those import paths with the `gomodUpdateImportPaths` `postUpdateOptions` ([ref](https://docs.renovatebot.com/modules/manager/gomod/#major-upgrades-of-dependencies)). This `postUpdateOptions` is supposed to be configured for the [`all-go-deps-main`](https://github.com/cilium/cilium/blob/36dd14d9c3ab8d0806c1f269327e8f6792a10664/.github/renovate.json5#L202-L216) update group, but this actually conflicts with the top level config [here](https://github.com/cilium/cilium/blob/36dd14d9c3ab8d0806c1f269327e8f6792a10664/.github/renovate.json5#L52-L54) that only configures `gomodTidy`. I ran some tests on a test repository and was able to confirm that in order to get `gomodUpdateImportPaths` to work as expected, what we need is to remove the `postUpdateOptions` config from the `all-go-deps-main` group and set `gomodUpdateImportPaths` in the top level `postUpdateOptions` instead of `gomodTidy` (we can remove `gomodTidy` because `gomodUpdateImportPaths` is a superset of it). The only difference will be that for renovate PRs that attempt to do a major go module upgrade, renovate will now also update the import paths (which depending on the dependency may still not be enough). With this PR I also remove the config block that disabled major updates for `go-github` as renovate should now be able to handle these. See cilium#42857 (review) Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: andy17663 <[email protected]>

HadrienPatte added 2 commits July 2, 2025 15:49

vendor: Update github.com/google/go-github to v73

fbfc468

Same as #40104, this is currently making #40325 fail Signed-off-by: Hadrien Patte <[email protected]>

deps: Disable renovate major upgrades for github.com/google/go-github

2d1bac8

Signed-off-by: Hadrien Patte <[email protected]>

github-actions bot added the cilium-cli This PR contains changes related with cilium-cli label Jul 2, 2025

maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 2, 2025

HadrienPatte marked this pull request as ready for review July 2, 2025 13:56

HadrienPatte requested review from a team as code owners July 2, 2025 13:57

HadrienPatte requested review from Artyop, derailed, joestringer and marseel July 2, 2025 13:57

tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Jul 2, 2025

maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 2, 2025

tklauser enabled auto-merge July 2, 2025 14:25

tklauser approved these changes Jul 2, 2025

View reviewed changes

derailed approved these changes Jul 2, 2025

View reviewed changes

joestringer approved these changes Jul 2, 2025

View reviewed changes

tklauser added this pull request to the merge queue Jul 2, 2025

Merged via the queue into main with commit 9e67910 Jul 2, 2025
399 of 405 checks passed

tklauser deleted the pr/HadrienPatte/go-github-73 branch July 2, 2025 17:25

HadrienPatte mentioned this pull request Aug 3, 2025

renovate: Fix go-github exclusion rule #40911

Merged

8 tasks

HadrienPatte mentioned this pull request Nov 20, 2025

renovate: Re-enable major updates for go-github #42903

Merged

cilium-release-bot bot added this to cilium v1.19.0 Feb 3, 2026

cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vendor: Update `github.com/google/go-github` to v73#40326

vendor: Update `github.com/google/go-github` to v73#40326
tklauser merged 2 commits intomainfrom
pr/HadrienPatte/go-github-73

HadrienPatte commented Jul 2, 2025 •

edited

Loading

Uh oh!

tklauser commented Jul 2, 2025

Uh oh!

tklauser left a comment

Uh oh!

joestringer left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

HadrienPatte commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tklauser commented Jul 2, 2025

Uh oh!

tklauser left a comment

Choose a reason for hiding this comment

Uh oh!

joestringer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HadrienPatte commented Jul 2, 2025 •

edited

Loading