multipool: Extend conformance-multipool to test local node routes#40191
Merged
dylandreimerink merged 5 commits intomainfrom Jun 25, 2025
Merged
multipool: Extend conformance-multipool to test local node routes#40191dylandreimerink merged 5 commits intomainfrom
dylandreimerink merged 5 commits intomainfrom
Conversation
pippolo84
added
release-note/minor
This comment was marked as outdated.
This comment was marked as outdated.
pippolo84
force-pushed
the
pr/pippolo84/multi-pool-local-node-route
branch
from
ffd0940 to
bf2586d
Compare
Member
Author
|
/ci-multi-pool |
pippolo84
force-pushed
the
pr/pippolo84/multi-pool-local-node-route
branch
from
bf2586d to
e5b7f13
Compare
pippolo84
changed the title
pippolo84
force-pushed
the
pr/pippolo84/multi-pool-local-node-route
branch
2 times, most recently
from
2af8ecd to
43050e6
Compare
Multi-Pool IPAM is compatible with local node routes too and does not require the installation of endpoint routes. Therefore, remove the validation check in the Helm chart. Signed-off-by: Fabio Falzoi <[email protected]>
Extend the Multi-Pool IPAM conformance workflow to test with endpoint routes disabled, that is, with local node routes enabled, in both tunneling and direct routing mode. Signed-off-by: Fabio Falzoi <[email protected]>
Multi-Pool IPAM is compatible with local node routes, therefore the requirement to enable endpoint routes should be removed from the documentation and the tutorial. Signed-off-by: Fabio Falzoi <[email protected]>
Multi-Pool IPAM is now compatible with tunneling too and it does not require native routing mode anymore. Therefore, in order to simplify the Multi-Pool IPAM tutorial in the docs, remove the options related to native routing. Related: #38483 Signed-off-by: Fabio Falzoi <[email protected]>
Since the introduction of concurrent testing in cilium-cli, the default test namespace name used is "cilium-test-1". Hence, update it in the multi-pool IPAM tutorial. Signed-off-by: Fabio Falzoi <[email protected]>
pippolo84
force-pushed
the
pr/pippolo84/multi-pool-local-node-route
branch
from
43050e6 to
fefe5be
Compare
pippolo84
added
area/documentation
Member
Author
|
/test |
pippolo84
removed
the
dont-merge/preview-only
marseel
approved these changes
Jun 25, 2025
maintainer-s-little-helper
bot
added
the
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-Pool IPAM is compatible with both local node routes and endpoint routes. Therefore, update the documentation, the related tutorial and extend the conformance workflow to cover the local node routes case too.
Example run of the two new matrix configs added in the conformance workflow:
Please review each commit individually