examples: Fix broken egress-policy-gateway example#40112
Merged
joestringer merged 1 commit intocilium:mainfrom Jul 9, 2025
Merged
examples: Fix broken egress-policy-gateway example#40112joestringer merged 1 commit intocilium:mainfrom
joestringer merged 1 commit intocilium:mainfrom
Conversation
|
Commits 776262d, c4e5af4, 8e4b2a4, ee54a0f do not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
github-actions
bot
added
the
kind/community-contribution
alagoutte
force-pushed
the
doc-egressgateways
branch
from
ee54a0f to
408913f
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
qmonnet
requested changes
Jun 19, 2025
Member
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
Thanks for this!
I've got some minor comments, please see inline below.
Can you please also slightly shorten your longest commit subjects to make CI happy?:
Error: ERROR:CUSTOM: Please avoid long commit subjects (max: 75, found: 78)
qmonnet
added
feature/egress-gateway
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
alagoutte
force-pushed
the
doc-egressgateways
branch
from
408913f to
70ff526
Compare
alagoutte
force-pushed
the
doc-egressgateways
branch
2 times, most recently
from
8cb9dbb to
a1c742d
Compare
Member
|
/test |
rgo3
approved these changes
Jun 25, 2025
Member
|
cc @carlos-abad did you test this example doc as part of your development for #39304 ? |
Member
|
There's two transient failures that both exhibit the symptom outlined in #40456 . I filed an issue for it, but I don't think this needs to block the merge. Thanks for fixing this up. I don't know why a broken example was added into the tree previously, but this fixes the example for me (at least to the point of adding the resource into the kube-apiserver). main: This PR: |
Previously:
$ k apply -f examples/kubernetes-egress-gateway/egress-gateway-policy.yaml
The CiliumEgressGatewayPolicy "egress-sample" is invalid:
* spec.egressGateway.nodeSelector.matchLabels.egress-node:
Invalid value: "boolean":
spec.egressGateway.nodeSelector.matchLabels.egress-node in body must be
of type string: "boolean"
* spec.egressGateways[0].nodeSelector.matchLabels.egress-node:
Invalid value:
"boolean": spec.egressGateways[0].nodeSelector.matchLabels.egress-node
in body must be of type string: "boolean"
* spec.egressGateways[1].nodeSelector.matchLabels.egress-node-2:
Invalid value: "boolean":
spec.egressGateways[1].nodeSelector.matchLabels.egress-node-2 in body
must be of type string: "boolean"
* spec.egressGateways[2].nodeSelector.matchLabels.egress-node-3:
Invalid value: "boolean":
spec.egressGateways[2].nodeSelector.matchLabels.egress-node-3 in body
must be of type string: "boolean"
Fixes: 9b81aed ("pkg/egressgateway: Add documentation for multigateway")
Signed-off-by: Alexis La Goutte <[email protected]>
Signed-off-by: Joe Stringer <[email protected]>
joestringer
force-pushed
the
doc-egressgateways
branch
from
a1c742d to
040b89a
Compare
Member
|
I squashed the commits together and clarified the impact / fix in the commit message. Merging. |
joestringer
added
release-note/misc
joestringer
changed the title
joestringer
added
the
needs-backport/1.18
Contributor
Thank Joe and the rest for fixing the issue. It looks like this was a pre-existing issue in the test file. Thank you for catching it. |
23 tasks
nbusseneau
added
backport-pending/1.18
github-actions
bot
added
backport-done/1.18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some minor typo and indent