Conversation
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
Member
Author
|
/test |
aanm
force-pushed
the
pr/move-logrus-to-slog
branch
from
e4b8f53 to
fabf971
Compare
aanm
added
area/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
Member
Author
|
/test |
aanm
force-pushed
the
pr/move-logrus-to-slog
branch
from
fabf971 to
703a603
Compare
Member
Author
|
/test |
aanm
force-pushed
the
pr/move-logrus-to-slog
branch
from
703a603 to
a2c65f1
Compare
Member
Author
|
/test |
aanm
force-pushed
the
pr/move-logrus-to-slog
branch
from
a2c65f1 to
df1ed72
Compare
Member
Author
|
/test |
aanm
force-pushed
the
pr/move-logrus-to-slog
branch
2 times, most recently
from
e850354 to
b52a84b
Compare
Member
Author
|
/test |
aanm
force-pushed
the
pr/move-logrus-to-slog
branch
from
b52a84b to
e83b856
Compare
Member
Author
|
/test |
aanm
force-pushed
the
pr/move-logrus-to-slog
branch
from
e83b856 to
b31c111
Compare
Member
Author
|
/test |
aanm
force-pushed
the
pr/move-logrus-to-slog
branch
from
b31c111 to
8e6c2f3
Compare
Member
Author
|
/test |
aanm
force-pushed
the
pr/move-logrus-to-slog
branch
from
8e6c2f3 to
5f42c07
Compare
Member
Author
|
/ci-gateway-api |
Member
Author
|
/test |
aanm
force-pushed
the
pr/move-logrus-to-slog
branch
from
5f42c07 to
b21ba92
Compare
Member
Author
|
/test |
aanm
force-pushed
the
pr/move-logrus-to-slog
branch
2 times, most recently
from
0130b01 to
658fa89
Compare
aanm
requested review from
christarazi,
derailed,
giorio94,
rastislavs,
sayboras,
smagnani96 and
ti-mo
aanm
added
release-note/major
sayboras
approved these changes
Jun 3, 2025
Member
sayboras
left a comment
sayboras
left a comment
There was a problem hiding this comment.
Looks good for gateway-api and envoy packages.
devodev
approved these changes
Jun 3, 2025
giorio94
approved these changes
Jun 3, 2025
rastislavs
approved these changes
Jun 3, 2025
christarazi
approved these changes
Jun 3, 2025
smagnani96
approved these changes
Jun 4, 2025
tklauser
reviewed
Jun 4, 2025
Add a multihandler slog.Handler so that we can add multiple handlers for one instance of slog.Logger. This is necessary to keep existing Cilium functionality that can log one message into multiple logger. Signed-off-by: André Martins <[email protected]>
With this commit we migrate the remaining Cilium code base to use slog and stop relying on logrus. Signed-off-by: André Martins <[email protected]>
Add a detector in the CI pipeline to catch duplicate attributes in slog logs. This prevents ambiguous or conflicting keys in structured logs, ensuring cleaner and more reliable log output. It also helps maintain consistency and simplifies downstream log processing and analysis. Signed-off-by: André Martins <[email protected]>
aanm
force-pushed
the
pr/move-logrus-to-slog
branch
from
4ac9df1 to
13e5b77
Compare
Member
Author
|
/test |
tklauser
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note for reviewers:
I couldn't split this into further commits given the changes in the pkg/logging package required changes everywhere else. 😞
I would appreciate closer review on the introduction of the multihandler (first commit) and on the second commit the changes done in the pkg/logging as well as the pkg/metrics to detect the presence of duplicate attributes in the slog log messages.