Skip to content

hubble: allow to enable/disable network policy correlation option again#39142

Merged
tklauser merged 1 commit intomainfrom
pr/tklauser/hubble-cell-fix-netpol-correlation-option
Apr 29, 2025
Merged

hubble: allow to enable/disable network policy correlation option again#39142
tklauser merged 1 commit intomainfrom
pr/tklauser/hubble-cell-fix-netpol-correlation-option

Conversation

@tklauser
Copy link
Copy Markdown
Member

@tklauser tklauser commented Apr 24, 2025

The referenced commit caused the Hubble network policy correlation to be always enabled, i.e. setting --hubble-network-policy-correlation-enabled no longer had any effect.

Fix this by correctly wiring up the config again and translating it into a parser option in newPayloadParser.

Fixes: 5df6f52 ("feat(hubble): decouple the payloadparser from hubble control plane.")
Fixes: #38368

No need to backport because 5df6f52/#38368 didn't make it into a released version yet.

@tklauser tklauser added release-note/misc This PR makes changes that have no direct user impact. sig/hubble labels Apr 24, 2025
@tklauser tklauser requested a review from a team as a code owner April 24, 2025 13:25
@tklauser tklauser requested a review from rolinh April 24, 2025 13:25
@tklauser
Copy link
Copy Markdown
Member Author

/test

The referenced commit caused the Hubble network policy correlation to be
always enabled, i.e. setting --hubble-network-policy-correlation-enabled
no longer had any effect.

Fix this by correctly wiring up the config again and translating it into
a parser option in newPayloadParser.

Fixes: 5df6f52 ("feat(hubble): decouple the payloadparser from hubble control plane.")

Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser force-pushed the pr/tklauser/hubble-cell-fix-netpol-correlation-option branch from 6e3a5c8 to 87d6f20 Compare April 24, 2025 13:50
@tklauser
Copy link
Copy Markdown
Member Author

/test

Copy link
Copy Markdown
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@tklauser tklauser added this pull request to the merge queue Apr 29, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 29, 2025
Merged via the queue into main with commit bea91ef Apr 29, 2025
286 of 289 checks passed
@tklauser tklauser deleted the pr/tklauser/hubble-cell-fix-netpol-correlation-option branch April 29, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants