Conversation
Member
Author
|
/test |
8 tasks
The referenced commit caused the Hubble network policy correlation to be always enabled, i.e. setting --hubble-network-policy-correlation-enabled no longer had any effect. Fix this by correctly wiring up the config again and translating it into a parser option in newPayloadParser. Fixes: 5df6f52 ("feat(hubble): decouple the payloadparser from hubble control plane.") Signed-off-by: Tobias Klauser <[email protected]>
6e3a5c8 to
87d6f20
Compare
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The referenced commit caused the Hubble network policy correlation to be always enabled, i.e. setting
--hubble-network-policy-correlation-enabledno longer had any effect.Fix this by correctly wiring up the config again and translating it into a parser option in newPayloadParser.
Fixes: 5df6f52 ("feat(hubble): decouple the payloadparser from hubble control plane.")
Fixes: #38368
No need to backport because 5df6f52/#38368 didn't make it into a released version yet.