Skip to content

Introduce --underlay-protocol#38523

Merged
pchaigno merged 5 commits intomainfrom
pr/pchaigno/introduce-underlay-protocol
Apr 2, 2025
Merged

Introduce --underlay-protocol#38523
pchaigno merged 5 commits intomainfrom
pr/pchaigno/introduce-underlay-protocol

Conversation

@pchaigno
Copy link
Copy Markdown
Member

@pchaigno pchaigno commented Mar 26, 2025

This pull request introduces a new tunneling flag called underlay-protocol. This new flag isn't doing anything in this pull request, but will be used in a ready-to-go follow up PR (I'm simply splitting to ease reviews). This new flag will allow us to select IPv6 as the underlay for our tunnels.

@pchaigno pchaigno added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. feature/ipv6 Relates to IPv6 protocol support labels Mar 26, 2025
@pchaigno pchaigno marked this pull request as ready for review March 26, 2025 13:27
@pchaigno pchaigno requested review from a team as code owners March 26, 2025 13:27
Copy link
Copy Markdown
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice!

@pchaigno pchaigno removed the request for review from joamaki March 28, 2025 09:45
@pchaigno pchaigno force-pushed the pr/pchaigno/introduce-underlay-protocol branch from 1a727c2 to 072873d Compare March 31, 2025 14:32
@pchaigno pchaigno requested a review from dylandreimerink April 1, 2025 08:43
@pchaigno pchaigno removed the request for review from ti-mo April 1, 2025 14:31
@pchaigno pchaigno enabled auto-merge April 1, 2025 14:45
@pchaigno pchaigno force-pushed the pr/pchaigno/introduce-underlay-protocol branch from 072873d to c76257e Compare April 1, 2025 14:49
@pchaigno pchaigno requested a review from squeed April 1, 2025 14:49
pchaigno added 3 commits April 2, 2025 13:33
This renaming is simply preparatory work for the next commit, which will
introduce a different kind of protocol choice related to our tunnels:
underlay protocols.

There are no functional changes in this commit.

Signed-off-by: Paul Chaignon <[email protected]>
This new flag allows chosing the underlay protocol for our VXLAN or
GENEVE overlay. It will be used in subsequent commits when deciding
which IP address to use for tunnel endpoints.

Signed-off-by: Paul Chaignon <[email protected]>
Support for the IPv6 tunneling underlay doesn't yet include support for
KPR (and all related features), IPsec, or WireGuard. Let's error out in
the agent if such a combination of options is given.

Signed-off-by: Paul Chaignon <[email protected]>
pchaigno added 2 commits April 2, 2025 13:33
This new Helm option sets --underlay-protocol, to configure the underlay
protocol for our VXLAN or GENEVE tunnels.

Signed-off-by: Paul Chaignon <[email protected]>
@pchaigno pchaigno force-pushed the pr/pchaigno/introduce-underlay-protocol branch from c76257e to 0628399 Compare April 2, 2025 11:33
@pchaigno pchaigno added this pull request to the merge queue Apr 2, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@pchaigno pchaigno added this pull request to the merge queue Apr 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@pchaigno pchaigno added this pull request to the merge queue Apr 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@pchaigno pchaigno added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit 2882e1d Apr 2, 2025
291 of 292 checks passed
@pchaigno pchaigno deleted the pr/pchaigno/introduce-underlay-protocol branch April 2, 2025 14:46
giorio94 added a commit that referenced this pull request Jun 18, 2025
Now that the long standing tunneling + IPv6-only limitation has been
lifted [1,2,3], let's enable this previously commented-out matrix entry
of the conformance-clustermesh workflow.

[1]: #38523
[2]: #38296
[3]: #39074

Signed-off-by: Marco Iorio <[email protected]>
giorio94 added a commit that referenced this pull request Jun 18, 2025
Now that the long standing tunneling + IPv6-only limitation has been
lifted [1,2,3], let's enable this previously commented-out matrix entry
of the conformance-clustermesh workflow.

[1]: #38523
[2]: #38296
[3]: #39074

Signed-off-by: Marco Iorio <[email protected]>
giorio94 added a commit that referenced this pull request Jun 23, 2025
Now that the long standing tunneling + IPv6-only limitation has been
lifted [1,2,3], let's enable this previously commented-out matrix entry
of the conformance-clustermesh workflow.

[1]: #38523
[2]: #38296
[3]: #39074

Signed-off-by: Marco Iorio <[email protected]>
giorio94 added a commit that referenced this pull request Jun 23, 2025
Now that the long standing tunneling + IPv6-only limitation has been
lifted [1,2,3], let's enable this previously commented-out matrix entry
of the conformance-clustermesh workflow.

[1]: #38523
[2]: #38296
[3]: #39074

Signed-off-by: Marco Iorio <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jun 24, 2025
Now that the long standing tunneling + IPv6-only limitation has been
lifted [1,2,3], let's enable this previously commented-out matrix entry
of the conformance-clustermesh workflow.

[1]: #38523
[2]: #38296
[3]: #39074

Signed-off-by: Marco Iorio <[email protected]>
wanglei4687 pushed a commit to wanglei4687/cilium that referenced this pull request Jun 26, 2025
Now that the long standing tunneling + IPv6-only limitation has been
lifted [1,2,3], let's enable this previously commented-out matrix entry
of the conformance-clustermesh workflow.

[1]: cilium#38523
[2]: cilium#38296
[3]: cilium#39074

Signed-off-by: Marco Iorio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature/ipv6 Relates to IPv6 protocol support ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants