datapath: provide node configuration at runtime#38244
Merged
ti-mo merged 14 commits intocilium:mainfrom Mar 27, 2025
Merged
Conversation
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
ti-mo
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
Contributor
Author
|
/test |
ti-mo
force-pushed
the
tb/datapath-node-config-struct
branch
from
a3c85aa to
6eb7d84
Compare
Contributor
Author
|
/test |
ti-mo
force-pushed
the
tb/datapath-node-config-struct
branch
2 times, most recently
from
7ec4930 to
11b10c5
Compare
Contributor
Author
|
/test |
ti-mo
force-pushed
the
tb/datapath-node-config-struct
branch
from
11b10c5 to
4a7dc99
Compare
Contributor
Author
|
/test |
ti-mo
force-pushed
the
tb/datapath-node-config-struct
branch
from
4a7dc99 to
65d6c9c
Compare
Contributor
Author
|
/test |
ti-mo
force-pushed
the
tb/datapath-node-config-struct
branch
from
65d6c9c to
e38c236
Compare
Contributor
Author
|
/test |
ti-mo
force-pushed
the
tb/datapath-node-config-struct
branch
from
e38c236 to
2ecb18c
Compare
Contributor
Author
|
/test |
smagnani96
approved these changes
Mar 21, 2025
Contributor
smagnani96
left a comment
smagnani96
left a comment
There was a problem hiding this comment.
This is simply amazing 😮 💯
Further additions to node_config.h will be rejected, assign to the work group overseeing the migration to runtime node configs. Signed-off-by: Timo Beckers <[email protected]>
Signed-off-by: Timo Beckers <[email protected]>
ti-mo
force-pushed
the
tb/datapath-node-config-struct
branch
from
2ecb18c to
267381d
Compare
Contributor
Author
|
/test |
Like previous commits, this wraps an existing runtime-generated config header to gradually migrate node configs to. Also converged on 'lnc' for the variable name for LocalNodeConfiguration, since we now sometimes have more than a few config-related structs in a given function. Signed-off-by: Timo Beckers <[email protected]>
ti-mo
force-pushed
the
tb/datapath-node-config-struct
branch
from
267381d to
308b9e7
Compare
Contributor
Author
|
/test |
qmonnet
approved these changes
Mar 25, 2025
Member
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
Awesome work!
Please find some suggestions on the docs below, none blocking
Signed-off-by: Timo Beckers <[email protected]>
Signed-off-by: Timo Beckers <[email protected]>
Signed-off-by: Timo Beckers <[email protected]>
Signed-off-by: Timo Beckers <[email protected]>
The preceding changes to dpgen allowed for removing the _1/_2 hack to stitch a MAC address together. Added MAC.As8() to help with converting the slice to an array. For historical reasons, union macaddr is 8 bytes and we can't turn it into 6 bytes since it's used as a map value. Signed-off-by: Timo Beckers <[email protected]>
Signed-off-by: Timo Beckers <[email protected]>
Signed-off-by: Timo Beckers <[email protected]>
ti-mo
force-pushed
the
tb/datapath-node-config-struct
branch
from
308b9e7 to
1abd006
Compare
Contributor
Author
|
/test |
doniacld
approved these changes
Mar 26, 2025
doniacld
approved these changes
Mar 26, 2025
Contributor
|
Nice! Good to see this landing. |
dylandreimerink
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
config.NodeBPF configuration object and embeds it into existingBPFLXC,BPFHostetc. configs.This configuration is currently generated based on
option.ConfigandLocalNodeConfiguration, but will eventually integrate with Hive.