Use more efficient SplitSeq instead of Split#38157
Merged
Conversation
tklauser
added
kind/cleanup
tklauser
requested review from
Artyop,
aditighag,
kaworu,
mhofstetter,
nathanjsweet,
pippolo84,
rastislavs,
smagnani96,
tommyp1ckles and
youngnick
tklauser
changed the title
SplitSeq instead of Split
github-actions
bot
added
hubble-cli
Member
Author
|
/test |
mhofstetter
approved these changes
Mar 12, 2025
smagnani96
approved these changes
Mar 12, 2025
Contributor
smagnani96
left a comment
smagnani96
left a comment
There was a problem hiding this comment.
Changes for encryption files LGTM, thanks!
Artyop
approved these changes
Mar 12, 2025
pippolo84
approved these changes
Mar 12, 2025
rastislavs
approved these changes
Mar 12, 2025
youngnick
approved these changes
Mar 12, 2025
gandro
approved these changes
Mar 13, 2025
borkmann
approved these changes
Mar 14, 2025
Replace Split in "for range strings.Split(...)" by Go 1.24's more
efficient, iterators-based strings.SplitSeq.
Generated using modernize by running:
go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...
and committing the relevant changes with some minor manual edits.
Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
pr/tklauser/splitseq
branch
from
abdece1 to
f47f617
Compare
Member
Author
|
/test |
Member
Author
|
Rebased to resolve merge conflict. @aditighag could you please take a look? Would be nice to have this merged before it picks up another merge conflict. |
Member
Author
|
@cilium/contributing @aditighag gentle ping for review |
pchaigno
approved these changes
Mar 25, 2025
Member
pchaigno
left a comment
pchaigno
left a comment
There was a problem hiding this comment.
Reviewing for contributing because it makes me sad to see such a straightforward PR having to go through that many reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
Splitinfor range strings.Split(...)by Go 1.24's more efficient, iterators-basedstrings.SplitSeq.Generated using modernize by running:
and committing the relevant changes with some minor manual edits.