iptables: no conntrack for overlay traffic#37990
Closed
julianwiedmann wants to merge 1 commit intocilium:mainfrom
Closed
iptables: no conntrack for overlay traffic#37990julianwiedmann wants to merge 1 commit intocilium:mainfrom
julianwiedmann wants to merge 1 commit intocilium:mainfrom
Conversation
julianwiedmann
added
area/datapath
julianwiedmann
force-pushed
the
1.18-overlay-conntrack
branch
from
94ff7de to
c0c8ca9
Compare
Member
Author
|
/test |
julianwiedmann
commented
Mar 7, 2025
Comment on lines
+1557
to
+1562
| if m.haveTunnel { | ||
| // TODO only install these when needed, uninstall otherwise | ||
| if err := m.addCiliumNoTrackOverlayRules(); err != nil { | ||
| return fmt.Errorf("cannot install overlay rules: %w", err) | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
@pippolo84 you might have more experience here - is cleaning up stale rules something we typically do? I don't see much evidence in iptables.go ...
Member
|
/scale-egw |
Member
|
@julianwiedmann Could you please rebase this PR? The scale test is otherwise failing because it is still using an old Cilium CLI version which does not support the latest flags required for these tests. |
VXLAN / GENEVE uses a uni-directional connection (src port is random, dst port is pre-defined), and conntrack'ing such traffic makes no sense. Ignore both the inbound traffic (based on L4 proto and dport) and the outbound traffic (based on the mark that our to-overlay program sets). Signed-off-by: Julian Wiedmann <[email protected]>
julianwiedmann
force-pushed
the
1.18-overlay-conntrack
branch
from
c0c8ca9 to
f5c9431
Compare
Member
|
/scale-egw |
Member
|
Results of the scale tests don't seem to show a significant improvement in terms of UDP throughput compared to an average run 😢: |
8 tasks
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
the
stale
|
This pull request has not seen any activity since it was marked stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VXLAN / GENEVE uses a uni-directional connection (src port is random, dst port is pre-defined), and conntrack'ing such traffic makes no sense.
Ignore both the inbound traffic (based on L4 proto and dport) and the outbound traffic (based on the mark that our to-overlay program sets).