ipam/aws: enhance findSuitableSubnet logic#37229
Merged
gandro merged 1 commit intocilium:mainfrom Mar 6, 2025
Merged
Conversation
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
Contributor
Author
|
/ci-ipsec-e2e |
ghost
reviewed
Jan 29, 2025
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
I feel like the new behaviour should be documented in Documentation/network/concepts/ipam/eni.rst, wdyt?
ghost
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
Contributor
Author
you are absolutely correct. Updated it. |
liyihuang
force-pushed
the
pr/liyihuang/enhance_find_subnet_logic
branch
from
02f2055 to
aeb3758
Compare
liyihuang
force-pushed
the
pr/liyihuang/enhance_find_subnet_logic
branch
2 times, most recently
from
6dd4971 to
b3924a8
Compare
Contributor
Author
|
/test |
Contributor
Author
|
/ci-e2e-upgrade |
Contributor
Author
|
/ci-ipsec-e2e |
Contributor
Author
|
/ci-eks |
1 similar comment
Contributor
Author
|
/ci-eks |
Contributor
Author
|
/ci-e2e-upgrade |
Contributor
Author
|
/ci-eks |
Contributor
Author
|
/ci-ipsec-e2e |
doniacld
reviewed
Feb 3, 2025
doniacld
reviewed
Feb 3, 2025
liyihuang
force-pushed
the
pr/liyihuang/enhance_find_subnet_logic
branch
from
e024e1e to
3bba137
Compare
Contributor
Author
|
/test |
- Implement struct to get route table from ec2 api - Implement new logic and function to enhance the findSuitableSubnet logic - Updates the unit test and mock ec2 api - Update the doc Signed-off-by: Liyi Huang <[email protected]>
liyihuang
force-pushed
the
pr/liyihuang/enhance_find_subnet_logic
branch
from
3bba137 to
57aeb10
Compare
Contributor
Author
|
/test |
asauber
approved these changes
Mar 6, 2025
maintainer-s-little-helper
bot
added
the
ready-to-merge
This was referenced Mar 11, 2025
HadrienPatte
added a commit
that referenced
this pull request
Aug 25, 2025
See #37229 Signed-off-by: Hadrien Patte <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
See #37229 Signed-off-by: Hadrien Patte <[email protected]>
3 tasks
HadrienPatte
added a commit
that referenced
this pull request
Nov 28, 2025
Fixes #43004 This PR does two main logical changes: * Add a safety check in `findSubnetInSameRouteTableWithNodeSubnet` to cover the case when a route table subnet is not present in the manager's subnets map. * Update `syncInfrastructure` to discard subnets from route tables that are not tracked in the manager's subnet map. I also added a new test case for each of those two scenarios. Related PR: #37229 Signed-off-by: Hadrien Patte <[email protected]>
HadrienPatte
added a commit
that referenced
this pull request
Nov 28, 2025
Fixes #43004 This PR does two main logical changes: * Add a safety check in `findSubnetInSameRouteTableWithNodeSubnet` to cover the case when a route table subnet is not present in the manager's subnets map. * Update `syncInfrastructure` to discard subnets from route tables that are not tracked in the manager's subnet map. I also added a new test case for each of those two scenarios. Related PR: #37229 Signed-off-by: Hadrien Patte <[email protected]>
HadrienPatte
added a commit
to DataDog/cilium
that referenced
this pull request
Dec 1, 2025
Fixes cilium#43004 Add a safety check in `findSubnetInSameRouteTableWithNodeSubnet` to cover the case when a route table subnet is not present in the manager's subnets map. I also added a new test case for this scenario. Related PR: cilium#37229 Signed-off-by: Hadrien Patte <[email protected]>
HadrienPatte
added a commit
that referenced
this pull request
Dec 1, 2025
Fixes #43004 Add a safety check in `findSubnetInSameRouteTableWithNodeSubnet` to cover the case when a route table subnet is not present in the manager's subnets map. I also added a new test case for this scenario. Related PR: #37229 Signed-off-by: Hadrien Patte <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
Fixes #43004 Add a safety check in `findSubnetInSameRouteTableWithNodeSubnet` to cover the case when a route table subnet is not present in the manager's subnets map. I also added a new test case for this scenario. Related PR: #37229 Signed-off-by: Hadrien Patte <[email protected]>
tklauser
pushed a commit
that referenced
this pull request
Dec 3, 2025
[ upstream commit 216081a ] Fixes #43004 Add a safety check in `findSubnetInSameRouteTableWithNodeSubnet` to cover the case when a route table subnet is not present in the manager's subnets map. I also added a new test case for this scenario. Related PR: #37229 Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Tobias Klauser <[email protected]>
tklauser
pushed a commit
that referenced
this pull request
Dec 3, 2025
[ upstream commit 216081a ] Fixes #43004 Add a safety check in `findSubnetInSameRouteTableWithNodeSubnet` to cover the case when a route table subnet is not present in the manager's subnets map. I also added a new test case for this scenario. Related PR: #37229 Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Tobias Klauser <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
[ upstream commit 216081a ] Fixes #43004 Add a safety check in `findSubnetInSameRouteTableWithNodeSubnet` to cover the case when a route table subnet is not present in the manager's subnets map. I also added a new test case for this scenario. Related PR: #37229 Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Tobias Klauser <[email protected]>
nddq
pushed a commit
to nddq/cilium
that referenced
this pull request
Feb 17, 2026
[ upstream commit 216081a ] Fixes cilium#43004 Add a safety check in `findSubnetInSameRouteTableWithNodeSubnet` to cover the case when a route table subnet is not present in the manager's subnets map. I also added a new test case for this scenario. Related PR: cilium#37229 Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Tobias Klauser <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know I need to rebease this one if #36922 get merged first.
Fixes: #32052