Conversation
Fix various things in the 06-lb test case: --backend does not exist anymore, we need to switch to --backends instead. Same for `cilium service inspect` that should have been `cilium service get` command. Comparing the deletion result from `cilium service delete` has changed to display the id as well. Thus, adapt results to compare against. The `IPV4=1; ./06-lb.sh` subtests seems to have some logical bugs, f.e. we add a legit service with id 10 and later on still expect the `cilium service list` to be empty, but right in the subsequent check we test whether the service with id 10 was the only one present?! The later added service with id 20 has a conflicting frontend vip, so that one cannot succeed. The `cilium endpoint ct dump` doesn't exist anymore, so just comment it out. Add a `cilium service list` after setting up the v4/v6 lb, so we can inspect the mappings. Fixes: c7d4002 ("Switch to spf13/cobra and spf13/viper to implement CLI & config") Signed-off-by: Daniel Borkmann <[email protected]>
tgraf
reviewed
Mar 20, 2017
| } | ||
|
|
||
| sudo cilium endpoint ct dump $SERVER1_ID | ||
| #sudo cilium endpoint ct dump $SERVER1_ID |
Contributor
There was a problem hiding this comment.
This is now cilium bpf ct list $SERVER1_ID
Contributor
There was a problem hiding this comment.
All commands which directly access bpf maps have been grouped in the bpf command to make it clear what uses the remote API and what uses direct access APIs
Contributor
|
Besides the |
mchalla
reviewed
Mar 20, 2017
| sudo cilium service update --frontend [::]:80 --backends [::1]:90,[::2]:91 --id 1 --rev 2> /dev/null || { | ||
| abort "Service should have been added" | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
You do not need to change the backend to backends since I fixed it in my lb_wrr review. I also took care of the remaining non working bits in this script. I am fine either ways. If you want to commit this one I will simply ignore this file. I will still need to call it backend though.
michi-covalent
pushed a commit
to michi-covalent/cilium
that referenced
this pull request
May 30, 2023
This should give us some additional information to debug flakes, e.g. for cilium#361 Signed-off-by: Tobias Klauser <[email protected]>
michi-covalent
pushed a commit
to michi-covalent/cilium
that referenced
this pull request
May 30, 2023
Add error to the debug output for ipcache check failures. This should help solve cilium#361. Signed-off-by: Jarno Rajahalme <[email protected]>
michi-covalent
added a commit
to michi-covalent/cilium
that referenced
this pull request
May 30, 2023
Add `--skip-ip-cache-check` flag with the default set to true. This is meant to be a temporary flag while we investigate what's causing the flake. Ref: cilium#361 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
pushed a commit
to michi-covalent/cilium
that referenced
this pull request
May 30, 2023
Follow-up for cilium#503 to address cilium/cilium-cli#503 (comment) Also add a comment so we don't forget to re-enable the check again once issue cilium#361 is resolved. Signed-off-by: Tobias Klauser <[email protected]>
yoursanonymous
pushed a commit
to yoursanonymous/cilium
that referenced
this pull request
Jan 31, 2026
* chore: add Cilium graduation blog post * update summary Signed-off-by: Bill Mulligan <[email protected]> --------- Signed-off-by: Bill Mulligan <[email protected]> Co-authored-by: Bill Mulligan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix various things in the 06-lb test case: --backend does not exist
anymore, we need to switch to --backends instead. Same for
cilium service inspectthat should have beencilium service getcommand.Comparing the deletion result from
cilium service deletehas changedto display the id as well. Thus, adapt results to compare against.
The
IPV4=1; ./06-lb.shsubtests seems to have some logical bugs,f.e. we add a legit service with id 10 and later on still expect the
cilium service listto be empty, but right in the subsequent checkwe test whether the service with id 10 was the only one present?!
The later added service with id 20 has a conflicting frontend vip,
so that one cannot succeed. The
cilium endpoint ct dumpdoesn'texist anymore, so just comment it out. Add a
cilium service listafter setting up the v4/v6 lb, so we can inspect the mappings.
Fixes: c7d4002 ("Switch to spf13/cobra and spf13/viper to implement CLI & config")
Signed-off-by: Daniel Borkmann [email protected]
cilium bpf ct list $SERVER1_IDbpf ct listchange, this looks good. I will rebase my other PR on top of this which adds the ability to resolve a hostname to multiple backends if the DNS replies with multiple IP records.