Skip to content

test: e2e tests for delegated IPAM#34839

Merged
pchaigno merged 1 commit intocilium:mainfrom
wedaly:delegated-ipam-e2e-tests
Sep 17, 2024
Merged

test: e2e tests for delegated IPAM#34839
pchaigno merged 1 commit intocilium:mainfrom
wedaly:delegated-ipam-e2e-tests

Conversation

@wedaly
Copy link
Copy Markdown

@wedaly wedaly commented Sep 11, 2024

Add E2E test for Cilium using a delegated IPAM plugin.
The test currently covers only IPv4; the test will be extended to cover IPv6 in a subsequent pull request.

Fixes: #34788

@wedaly wedaly requested review from a team as code owners September 11, 2024 20:42
@wedaly wedaly requested review from aanm and tklauser September 11, 2024 20:42
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 11, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 11, 2024
@wedaly wedaly force-pushed the delegated-ipam-e2e-tests branch 2 times, most recently from d890a25 to 47848b0 Compare September 11, 2024 20:50
@dylandreimerink dylandreimerink added the release-note/ci This PR makes changes to the CI. label Sep 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 12, 2024
@wedaly wedaly force-pushed the delegated-ipam-e2e-tests branch 3 times, most recently from 8f4f788 to d1b27f8 Compare September 12, 2024 19:19
@tklauser
Copy link
Copy Markdown
Member

/test

@wedaly wedaly force-pushed the delegated-ipam-e2e-tests branch 2 times, most recently from 3a8540f to 61d9391 Compare September 13, 2024 16:28
Copy link
Copy Markdown
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @cilium/github-sec

@joestringer joestringer removed the request for review from aanm September 13, 2024 21:21
@joestringer
Copy link
Copy Markdown
Member

(dropped @aanm from review as I covered @cilium/github-sec codeowner, but feel free to review as well)

@pchaigno pchaigno requested a review from tklauser September 16, 2024 06:48
@pchaigno pchaigno enabled auto-merge September 16, 2024 06:48
@joestringer joestringer added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Sep 16, 2024
Add E2E test for Cilium using a delegated IPAM plugin.
The test currently covers only IPv4; the test will be extended
to cover IPv6 in a subsequent pull request.

Signed-off-by: Will Daly <[email protected]>
auto-merge was automatically disabled September 16, 2024 20:15

Head branch was pushed to by a user without write access

@wedaly wedaly force-pushed the delegated-ipam-e2e-tests branch from 61d9391 to 8722b78 Compare September 16, 2024 20:15
@wedaly
Copy link
Copy Markdown
Author

wedaly commented Sep 16, 2024

Rebased to resolve merge conflict in .github/ariane-config.yaml

@tklauser could you please take another look? thanks!

@pchaigno pchaigno removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Sep 17, 2024
@pchaigno
Copy link
Copy Markdown
Member

/test

@pchaigno pchaigno enabled auto-merge September 17, 2024 06:40
Copy link
Copy Markdown
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @wedaly!

@pchaigno pchaigno added this pull request to the merge queue Sep 17, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 17, 2024
Merged via the queue into cilium:main with commit d06510e Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CFP: E2E tests for delegated IPAM

5 participants