gha: shorten conformance-externalworkloads cluster name#33939
Merged
joamaki merged 1 commit intocilium:mainfrom Jul 23, 2024
Merged
gha: shorten conformance-externalworkloads cluster name#33939joamaki merged 1 commit intocilium:mainfrom
joamaki merged 1 commit intocilium:mainfrom
Conversation
The cluster name is used both for the GKE cluster and in the Cilium's
context. However, since [1] Cilium imposes a maximum cluster name
length of 32 characters. Given the recent increase in the length of
the run_id, the generated cluster name is dangerously close to the
limit, and can easily exceed it in case of forks if the repository
owner name is slightly longer. Hence, let's trim the final suffix
to get back a few more characters.
[1]: 3ba429d0f2f6 ("options: formalize and validate cluster name format")
Signed-off-by: Marco Iorio <[email protected]>
giorio94
added
area/CI
Member
Author
|
/test |
Contributor
|
Hey, not here to hijack Viktor's reviewer role, but do we really need the |
Member
Author
Not totally sure on the background there, honestly, but all the other workflows also follow a similar pattern for the name. Another possibility could be just explicitly configuring a shorter cluster name for Cilium, but it didn't seem necessary at the moment (also to keep the workflow consistent with the others). |
viktor-kurchenko
approved these changes
Jul 23, 2024
marseel
approved these changes
Jul 23, 2024
giorio94
added
the
ready-to-merge
10 tasks
github-actions
bot
added
backport-done/1.16
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Jul 30, 2024
Shorten cluster names to avoid getting this error:
Error: Unable to install Cilium: execution error at (cilium/templates/validate.yaml:100:5):
The cluster name is invalid: must not be more than 32 characters.
Configure 'upgradeCompatibility' to 1.15 or earlier to temporarily
skip this check at your own risk
Ref: cilium/cilium#33939
Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Jul 31, 2024
Shorten cluster names to avoid getting this error:
Error: Unable to install Cilium: execution error at (cilium/templates/validate.yaml:100:5):
The cluster name is invalid: must not be more than 32 characters.
Configure 'upgradeCompatibility' to 1.15 or earlier to temporarily
skip this check at your own risk
Ref: cilium/cilium#33939
Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
that referenced
this pull request
Aug 5, 2024
[ cherry-picked from cilium/cilium-cli repository ]
Shorten cluster names to avoid getting this error:
Error: Unable to install Cilium: execution error at (cilium/templates/validate.yaml:100:5):
The cluster name is invalid: must not be more than 32 characters.
Configure 'upgradeCompatibility' to 1.15 or earlier to temporarily
skip this check at your own risk
Ref: #33939
Signed-off-by: Michi Mutsuzaki <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
[ cherry-picked from cilium/cilium-cli repository ]
Shorten cluster names to avoid getting this error:
Error: Unable to install Cilium: execution error at (cilium/templates/validate.yaml:100:5):
The cluster name is invalid: must not be more than 32 characters.
Configure 'upgradeCompatibility' to 1.15 or earlier to temporarily
skip this check at your own risk
Ref: #33939
Signed-off-by: Michi Mutsuzaki <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cluster name is used both for the GKE cluster and in the Cilium's context. However, since [1] Cilium imposes a maximum cluster name length of 32 characters. Given the recent increase in the length of the run_id, the generated cluster name is dangerously close to the limit, and can easily exceed it in case of forks if the repository owner name is slightly longer. Hence, let's trim the final suffix to get back a few more characters.
[1]: 3ba429d0f2f6 ("options: formalize and validate cluster name format")