Repository navigation
LB-IPAM: Change default CiliumLoadBalancerIPPool behavior and remove deprecated cidrs field from CiliumLoadBalancerIPPool - #33151
Merged
Conversation
dylandreimerink
added
kind/cleanup
Member
Author
|
/test |
dylandreimerink
marked this pull request as ready for review
June 14, 2024 12:44
dylandreimerink
requested review from
a user,
joamaki,
rastislavs,
viktor-kurchenko and
youngnick
June 14, 2024 12:44
sayboras
approved these changes
Jun 14, 2024
sayboras
left a comment
sayboras
left a comment
Member
There was a problem hiding this comment.
Looks good for Ingress and Gateway API related files.
joamaki
approved these changes
Jun 14, 2024
joamaki
left a comment
joamaki
left a comment
Contributor
There was a problem hiding this comment.
operator & k8s changes LGTM
viktor-kurchenko
approved these changes
Jun 17, 2024
youngnick
removed their request for review
June 17, 2024 11:27
dylandreimerink
force-pushed
the
pr/dylandreimerink/lb-ipam-1.16-cleanup
branch
from
June 17, 2024 12:05
742b62b to
3b42515
Compare
Member
Author
|
/test |
dylandreimerink
force-pushed
the
pr/dylandreimerink/lb-ipam-1.16-cleanup
branch
from
June 18, 2024 07:03
3b42515 to
4efbad9
Compare
In v1.15, we introduced this setting and defaulted to `no` for `AllowFirstLastIP` to preserve the previous behavior. However, in most cases its preferable to default to `yes`. Users should explicitly set this field to their desired value if they don't want the behavior of pools to change. Signed-off-by: Dylan Reimerink <[email protected]>
Originally the CiliumLoadBalancerIPPool only had CIDRs, and thus a field called `cidrs` containing a list of CIDRs. In v1.15 it became possible to specify ranges of IPs with a start and end IP. A new field was added called `blocks` which was treated as an alias of `cidrs`. This was done to allow for a smooth transition. This commit removes the `cidrs` field to complete the transition. Signed-off-by: Dylan Reimerink <[email protected]>
dylandreimerink
force-pushed
the
pr/dylandreimerink/lb-ipam-1.16-cleanup
branch
from
June 18, 2024 10:29
4efbad9 to
50201a9
Compare
Member
Author
|
/test |
maintainer-s-little-helper
Bot
added
the
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the default value of the optional
AllowFirstLastIPssetting so pools allow for allocation of the first and last IP by default. This defaulted to not allowing the allocation beforehand. v1.15 introduced the option, users can preserve existing behavior by explicitly specifyingAllowFirstLastIPs.This PR also removes the
cidrsfield from theCiliumLoadBalancerIPPool.spec. v1.15 introduced non-cidr ranges, thus the name didn't match anymore. v1.15 addedblocksto replacecidrs. Both fields were merged, so they acted as alias. Now in v1.16 we are cleaning up the deprecated field and removingcidrs. Users should make sure to switch to usingblocksbefore the upgrade.Fixes: #28590
Fixes: #28591