Repository navigation
daemon: Restore health IPs from local ciliumnode resource - #30383
Conversation
19a3cb9 to
bb8ab0d
Compare
derailed
left a comment
There was a problem hiding this comment.
@haozhangami Thank you for this update!
69c2870 to
f83ba65
Compare
giorio94
left a comment
There was a problem hiding this comment.
Thanks @haozhangami for your PR!
Looks a valuable improvement to me. Unfortunately, it appears that the restoration logic doesn't work as intended. I've left a few more details about the reasons in the inline comments, as well as a bunch of additional suggestions.
f83ba65 to
c631d9e
Compare
c631d9e to
8de201c
Compare
giorio94
left a comment
There was a problem hiding this comment.
Thanks! I've performed a few tests with both Kubernetes and ClusterPool IPAM modes and confirmed that this actually fixes the Health IP bouncing as expected.
Code changes look overall good to me. I've left one more comment inline (the last) concerning the handling of IP families change. Besides that, just a couple of possible additional clean-ups.
Finally, I've requested a review from the sig-ipam team to also get their feedback given that this PR touches IPAM-related logic.
c04b92f to
b820708
Compare
giorio94
left a comment
There was a problem hiding this comment.
Looks good to me. Just one final comment which I overlooked earlier.
b820708 to
afc0fdc
Compare
Currently, although health IPs are recorded in the ciliumnode resource, cilium will allocate a new health IP when the cilium agent restarts. In addition, it will cause unnecessary node update events. This patch obtains health IPs from ciliumnode and restores them. If the restoration fails, a new health IP is allocated. Signed-off-by: Hao Zhang <[email protected]>
afc0fdc to
8a23e15
Compare
|
/test |
derailed
left a comment
There was a problem hiding this comment.
@haozhangami Thank you for the updates!
The latest cilium version will restore health IPs from the local ciliumnode resource. This patch can be removed when we upgrade to the new version. backport cilium#30383 Ref: issue#1908
Currently, although health IPs are recorded in the ciliumnode resource, cilium will allocate a new health IP when the cilium agent restarts. In addition, it will cause unnecessary node update events.
This patch obtains health IPs from ciliumnode and restores them. If the restoration fails, a new health IP is allocated.