api: Introduce & expose endpoint controller statuses by tgraf · Pull Request #2720 · cilium/cilium

tgraf · 2018-02-05T23:29:07Z

$ cilium status --all-controllers
[...]
Controller Status (0/2 failing)
  Name                               Last success   Last error   Count   Message
  sync-identity-to-k8s-pod (56326)   36s ago        never        0       no error
  sync-identity-to-k8s-pod (29898)   32s ago        never        0       no error

    $ cilium status -o json
      "controllers": [
        {
          "configuration": {
            "error-retry": true,
            "interval": "1m0s"
          },
          "name": "sync-identity-to-k8s-pod (56326)",
          "status": {
            "last-failure-timestamp": "0001-01-01T00:00:00.000Z",
            "last-success-timestamp": "2018-02-05T17:43:34.099-08:00",
            "success-count": 1
          },
          "uuid": "247d5d37-0adf-11e8-aa78-080027559fd9"
        },
        {
          "configuration": {
            "error-retry": true,
            "interval": "1m0s"
          },
          "name": "sync-identity-to-k8s-pod (29898)",
          "status": {
            "last-failure-timestamp": "0001-01-01T00:00:00.000Z",
            "last-success-timestamp": "2018-02-05T17:43:37.997-08:00",
            "success-count": 1
          },
          "uuid": "26d05710-0adf-11e8-aa78-080027559fd9"
        }

houndci-bot · 2018-02-05T23:29:17Z

api/v1/models/controller_statuses.go

exported type ControllerStatuses should have comment or be unexported

houndci-bot · 2018-02-05T23:29:17Z

api/v1/models/controller_status.go

exported type ControllerStatusStatus should have comment or be unexported

houndci-bot · 2018-02-05T23:29:17Z

api/v1/models/controller_status.go

exported type ControllerStatusConfiguration should have comment or be unexported

houndci-bot · 2018-02-05T23:29:18Z

api/v1/models/controller_status.go

exported type ControllerStatus should have comment or be unexported

tgraf · 2018-02-05T23:30:47Z

test-me-please

ianvernon

LGTM apart from some minor nitpicks.

ianvernon · 2018-02-05T23:30:32Z

api/v1/openapi.yaml

Typo: timestamp

ianvernon · 2018-02-05T23:31:34Z

pkg/controller/controller.go

In other structures we have put the mutex above all of the resources which should be accessed under that lock - can you do that here?

tgraf · 2018-02-06T01:47:15Z

test-me-please

ianvernon · 2018-02-06T02:38:21Z

test-me-please

ianvernon · 2018-02-06T02:38:30Z

Error from previous build is odd:

02:28:04 pkg/client/client.go:218: time.Since(t).Truncate undefined (type time.Duration has no field or method Truncate)
02:28:04 Makefile:71: recipe for target 'tests-consul-ginkgo' failed

EDIT: never mind, there were new changes to the PR. I will review when the above error has been resolved.

Signed-off-by: Thomas Graf <[email protected]>

tgraf · 2018-02-06T10:09:25Z

test-me-please

tgraf · 2018-02-06T10:34:14Z

test-me-please

tgraf · 2018-02-06T10:54:20Z

02:28:04 pkg/client/client.go:218: time.Since(t).Truncate undefined (type time.Duration has no field or method Truncate)

Truncate() is not available in go 1.8. I've worked around it.

tgraf · 2018-02-06T11:57:16Z

test-me-please

raybejjani

LGTM

raybejjani · 2018-02-06T12:01:13Z

pkg/client/client.go

Could you docuement what allControllers does?

raybejjani · 2018-02-06T12:02:11Z

pkg/client/client.go

Since we only do something when status != nil, we can continue when status == nil and avoid the indent.

raybejjani · 2018-02-06T12:06:58Z

pkg/client/client.go

I found this logic a bit difficult. Why not:

if status.ConsecutiveFailureCount > 0 { nFailing++ } else if !allControllers { continue }

or a switch on the same clauses.

The global controller health will become the standard health overview of the agent as it will show the status of all async operations: $ cilium status --all-controllers [...] Controller Status (0/2 failing) Name Last success Last error Count Message sync-identity-to-k8s-pod (56326) 36s ago never 0 no error sync-identity-to-k8s-pod (29898) 32s ago never 0 no error $ cilium status -o json "controllers": [ { "configuration": { "error-retry": true, "interval": "1m0s" }, "name": "sync-identity-to-k8s-pod (56326)", "status": { "last-failure-timestamp": "0001-01-01T00:00:00.000Z", "last-success-timestamp": "2018-02-05T17:43:34.099-08:00", "success-count": 1 }, "uuid": "247d5d37-0adf-11e8-aa78-080027559fd9" }, { "configuration": { "error-retry": true, "interval": "1m0s" }, "name": "sync-identity-to-k8s-pod (29898)", "status": { "last-failure-timestamp": "0001-01-01T00:00:00.000Z", "last-success-timestamp": "2018-02-05T17:43:37.997-08:00", "success-count": 1 }, "uuid": "26d05710-0adf-11e8-aa78-080027559fd9" } Signed-off-by: Thomas Graf <[email protected]>

tgraf · 2018-02-06T12:28:50Z

test-me-please

[ cherry-picked from cilium/cilium-cli repository ] Also update kubeadm.k8s.io API version from v1beta2 to v1beta3. Ref: #2720 Suggested-by: Joe Stringer <[email protected]> Signed-off-by: Michi Mutsuzaki <[email protected]>

tgraf added kind/enhancement This would improve or streamline existing functionality. area/daemon Impacts operation of the Cilium daemon. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Feb 5, 2018

tgraf requested review from a team as code owners February 5, 2018 23:29

houndci-bot reviewed Feb 5, 2018

View reviewed changes

ianvernon approved these changes Feb 5, 2018

View reviewed changes

tgraf force-pushed the controller-status branch from 66944a6 to 65481f1 Compare February 6, 2018 01:45

tgraf requested a review from a team February 6, 2018 01:45

tgraf requested review from a team as code owners February 6, 2018 01:45

tgraf added release-note/major This PR introduces major new functionality to Cilium. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Feb 6, 2018

tgraf requested a review from ianvernon February 6, 2018 01:47

tgraf added 2 commits February 6, 2018 02:09

api: Introduce & expose endpoint controller statuses

f088186

Signed-off-by: Thomas Graf <[email protected]>

controller: Split code into manager.go

0d2e42c

Signed-off-by: Thomas Graf <[email protected]>

tgraf force-pushed the controller-status branch from 65481f1 to 88753d8 Compare February 6, 2018 10:09

tgraf force-pushed the controller-status branch from 88753d8 to c9b5480 Compare February 6, 2018 10:33

tgraf added the pending-review label Feb 6, 2018

raybejjani approved these changes Feb 6, 2018

View reviewed changes

tgraf force-pushed the controller-status branch from c9b5480 to 5b57b4d Compare February 6, 2018 12:20

aanm approved these changes Feb 6, 2018

View reviewed changes

tgraf merged commit cb6890e into master Feb 6, 2018

tgraf deleted the controller-status branch February 6, 2018 14:01

Conversation

tgraf commented Feb 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgraf commented Feb 5, 2018

Uh oh!

ianvernon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgraf commented Feb 6, 2018

Uh oh!

ianvernon commented Feb 6, 2018

Uh oh!

ianvernon commented Feb 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgraf commented Feb 6, 2018

Uh oh!

tgraf commented Feb 6, 2018

Uh oh!

tgraf commented Feb 6, 2018

Uh oh!

tgraf commented Feb 6, 2018

Uh oh!

raybejjani left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgraf commented Feb 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tgraf commented Feb 5, 2018 •

edited

Loading

ianvernon left a comment •

edited

Loading

ianvernon commented Feb 6, 2018 •

edited

Loading