Fix for data race in IP release features#18217
Merged
nbusseneau merged 1 commit intocilium:masterfrom Dec 13, 2021
Merged
Conversation
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
hemanthmalla
force-pushed
the
hemanth.malla/ip_release_data_race
branch
from
deb336e to
643f0e5
Compare
Fixes: cilium#18204 Signed-off-by: Hemanth Malla <[email protected]>
hemanthmalla
force-pushed
the
hemanth.malla/ip_release_data_race
branch
from
643f0e5 to
55e1482
Compare
Member
|
/test-race Edit: Looks like we hit a few data races and they are known #17914. |
Member
|
/test Edit: |
joestringer
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
gandro
approved these changes
Dec 13, 2021
Member
gandro
left a comment
gandro
left a comment
There was a problem hiding this comment.
Looks good to me. Note that this fixes an issue in the Travis pipeline, not the Jenkins race pipeline.
Also marking for backport as the underlying code is scheduled for a v1.11 backport too.
Member
|
Marking this as ready to merge, as this is impacting the stability of our Travis pipeline and all test failures are unrelated as per Chris' investigation above. |
gandro
added
the
ready-to-merge
Member
|
@hemanthmalla Thanks for the PR! Merging. |
tklauser
added
backport-done/1.11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #18204
Signed-off-by: Hemanth Malla [email protected]