Skip to content

loader: investigate lost BPF complexity coverage #47647

Description

@smagnani96

When porting variables from macros to dynamic config variables, we've lost coverage in complexity tests. An example is the EVENTS_MAP_RATE_LIMIT:

  • in v1.19, we were running complexity tests with -DEVENTS_MAP_RATE_LIMIT=1000
  • in v1.20 we ported it to a CONFIG variable, without adding it to the test permutations (or removing it afterwards to stay in the limit, haven't double checked). This means the respective codepath (i.e., if (CONFIG(events_map_rate_limit) > 0)) is never verified. (occurred on this backport)

This means we're potentially hitting complexity issues we're not aware of in main.

Metadata

Metadata

Labels

area/CIContinuous Integration testing issue or flakearea/datapathImpacts bpf/ or low-level forwarding details, including map management and monitor messages.area/loaderImpacts the loading of BPF programs into the kernel.kind/bugThis is a bug in the Cilium logic.kind/complexity-issueRelates to BPF complexity or program size issueskind/regressionThis functionality worked fine before, but was broken in a newer release of Cilium.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions