-
Notifications
You must be signed in to change notification settings - Fork 3.7k
NodeNeighborLinkUpdater memory usage regression #39499
Copy link
Copy link
Closed
Labels
area/agentCilium agent related.Cilium agent related.kind/bugThis is a bug in the Cilium logic.This is a bug in the Cilium logic.kind/regressionThis functionality worked fine before, but was broken in a newer release of Cilium.This functionality worked fine before, but was broken in a newer release of Cilium.release-blocker/1.18This issue will prevent the release of the next version of Cilium.This issue will prevent the release of the next version of Cilium.sig/scalabilityImpacts how well Cilium handles a high rate of events or churn.Impacts how well Cilium handles a high rate of events or churn.
Description
Metadata
Metadata
Assignees
Labels
area/agentCilium agent related.Cilium agent related.kind/bugThis is a bug in the Cilium logic.This is a bug in the Cilium logic.kind/regressionThis functionality worked fine before, but was broken in a newer release of Cilium.This functionality worked fine before, but was broken in a newer release of Cilium.release-blocker/1.18This issue will prevent the release of the next version of Cilium.This issue will prevent the release of the next version of Cilium.sig/scalabilityImpacts how well Cilium handles a high rate of events or churn.Impacts how well Cilium handles a high rate of events or churn.
Type
Projects
Status
Done
Is there an existing issue for this?
Version
equal or higher than v1.17.3 and lower than v1.18.0
What happened?
Memory regression is happening on main.
Since #39001 was merged, memory usage of cilium-agent increased by 3-4% in scale-tests. Most of the memory increase is coming from health-reporting:
It seems fairly excessive to report health per each node and each service backed:
cilium/pkg/node/manager/manager.go
Line 1393 in 07f37d3
Proposal:
Instead of reporting health per each backend/node, let's report health one time with number of refreshed and failed entries.
How can we reproduce the issue?
CI/scale-test
Cilium Version
main
Kernel Version
N/A
Kubernetes Version
N/A
Regression
yes
Sysdump
Pprofs in zip file
files.zip
Relevant log output
Anything else?
No response
Cilium Users Document
Code of Conduct