Refactor internals module part 4
#1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1432 +/- ##
==========================================
+ Coverage 91.84% 91.87% +0.02%
==========================================
Files 38 38
Lines 17571 17507 -64
==========================================
- Hits 16138 16084 -54
+ Misses 1433 1423 -10 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Feb 12, 2024
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits add a way to construct an
Mdfwithout going through anOf, and to get an ordinal and flags back out without going throughOf. With that the last uses ofOfare gone.A final commit is to move
cycle_to_yoandyo_to_cycleand the related array to thedatemodule.I found one comment in a backup branch that was better to have with the previous PR, sorry. Just stylistic comment changes to
IsoWeek.