Make rkyv feature imply size_32
#1383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 0.4.x #1383 +/- ##
==========================================
+ Coverage 91.69% 91.72% +0.03%
==========================================
Files 38 38
Lines 17608 17267 -341
==========================================
- Hits 16145 15839 -306
+ Misses 1463 1428 -35 ☔ View full report in Codecov by Sentry. |
Member
|
Could we instead change our feature forwarding so that |
Collaborator
Author
|
I don't think we can because the feature name |
Member
|
We can write |
Collaborator
Author
|
I'll give it a try. |
pitdicker
force-pushed
the
docsrs_rkyv_feature
branch
from
606754d to
75c1121
Compare
Collaborator
Author
|
Now that features |
pitdicker
force-pushed
the
docsrs_rkyv_feature
branch
from
75c1121 to
f0cf98c
Compare
Collaborator
Author
|
Do we want to bump to 0.4.33 in this PR? |
pitdicker
changed the title
rkyv-64rkyv feature implie size_32
pitdicker
changed the title
rkyv feature implie size_32rkyv feature imply size_32
pitdicker
force-pushed
the
docsrs_rkyv_feature
branch
from
f0cf98c to
b59d3c9
Compare
djc
reviewed
Jan 24, 2024
Member
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Do we want to bump to 0.4.33 in this PR?
Yes, please!
Cargo.toml
Outdated
| rkyv-16 = ["dep:rkyv", "rkyv?/size_16"] | ||
| rkyv-32 = ["dep:rkyv", "rkyv?/size_32"] | ||
| rkyv-64 = ["dep:rkyv", "rkyv?/size_64"] | ||
| rkyv-validation = ["dep:rkyv", "rkyv?/validation"] |
Member
There was a problem hiding this comment.
So I think this one is now odd because rkyv-validation doesn't pick a size? I'd propose that we leave dep:rkyv out of rkyv-validation and only leave rkyv?/validation in there so that it will only activate the downstream feature if any of the other features have been used to enable rkyv (and pick a size).
Collaborator
Author
There was a problem hiding this comment.
I tried both of your suggestions, but then it doesn't work out for all combinations:
cargo check --features=rkyv-64,rkyv-validation
Checking rkyv v0.7.43
error: "size_32" and "size_64" are mutually-exclusive features. You may need to set `default-features = false` or compile with `--no-default-features`.
--> C:\Users\paul\.cargo\registry\src\index.crates.io-6f17d22bba15001f\rkyv-0.7.43\src\macros.rs:127:1
|
127 | / core::compile_error!(
128 | | "\"size_32\" and \"size_64\" are mutually-exclusive features. You may need to set \
129 | | `default-features = false` or compile with `--no-default-features`."
130 | | );
| |_^
error: could not compile `rkyv` (lib) due to previous error
Member
There was a problem hiding this comment.
I think we can make do without the validation -> dep:rkyv edge? It seems to work for me.
pitdicker
commented
Jan 24, 2024
pitdicker
force-pushed
the
docsrs_rkyv_feature
branch
from
d7b244e to
c67019b
Compare
Collaborator
Author
|
Set the date to today. Do we want to get #1384 in first? |
pitdicker
force-pushed
the
docsrs_rkyv_feature
branch
from
c67019b to
09a8da0
Compare
Member
|
Published to crates.io, thanks! |
Collaborator
Author
|
That is quick. You too! |
Collaborator
Author
Closed
montekki
referenced
this pull request
in matter-labs/zksync-withdrawal-finalizer
Jan 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [chrono](https://togithub.com/chronotope/chrono) | workspace.dependencies | patch | `0.4.32` -> `0.4.33` | --- ### Release Notes <details> <summary>chronotope/chrono (chrono)</summary> ### [`v0.4.33`](https://togithub.com/chronotope/chrono/releases/tag/v0.4.33): 0.4.33 [Compare Source](https://togithub.com/chronotope/chrono/compare/v0.4.32...v0.4.33) #### What's Changed - Fixed typo in Duration::hours() exception by [@​danwilliams](https://togithub.com/danwilliams) in [https://github.com/chronotope/chrono/pull/1384](https://togithub.com/chronotope/chrono/pull/1384) - Make `rkyv` feature imply `size_32` by [@​pitdicker](https://togithub.com/pitdicker) in [https://github.com/chronotope/chrono/pull/1383](https://togithub.com/chronotope/chrono/pull/1383) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matter-labs/zksync-withdrawal-finalizer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
referenced
this pull request
in smartive/zitadel-rust
Jan 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [chrono](https://togithub.com/chronotope/chrono) | dev-dependencies | patch | `0.4.32` -> `0.4.33` | --- ### Release Notes <details> <summary>chronotope/chrono (chrono)</summary> ### [`v0.4.33`](https://togithub.com/chronotope/chrono/releases/tag/v0.4.33): 0.4.33 [Compare Source](https://togithub.com/chronotope/chrono/compare/v0.4.32...v0.4.33) #### What's Changed - Fixed typo in Duration::hours() exception by [@​danwilliams](https://togithub.com/danwilliams) in [https://github.com/chronotope/chrono/pull/1384](https://togithub.com/chronotope/chrono/pull/1384) - Make `rkyv` feature imply `size_32` by [@​pitdicker](https://togithub.com/pitdicker) in [https://github.com/chronotope/chrono/pull/1383](https://togithub.com/chronotope/chrono/pull/1383) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/smartive/zitadel-rust). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the build failure on docs.rs, see #1368 (comment) and #1380.
Fixes #1380.