Don't let unstable-locales imply the alloc feature
#1307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitdicker
force-pushed
the
unstable_locales_no_alloc
branch
from
97f7613 to
9c23d98
Compare
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1307 +/- ##
=======================================
Coverage 91.00% 91.00%
=======================================
Files 38 38
Lines 17068 17068
=======================================
Hits 15533 15533
Misses 1535 1535
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pitdicker
force-pushed
the
unstable_locales_no_alloc
branch
2 times, most recently
from
f40e155 to
b0adf08
Compare
Collaborator
Author
|
All localized formatting methods now also depend on |
pitdicker
changed the title
unstable-locales depend on alloc featureunstable-locales imply the alloc feature
Member
|
I'm okay with this, but |
pitdicker
force-pushed
the
unstable_locales_no_alloc
branch
from
b0adf08 to
94d9e65
Compare
Collaborator
Author
It did not bother me enough yet 😄. I have added a commit to clean that up. |
djc
approved these changes
Sep 23, 2023
Collaborator
Author
|
Nice, this also reduced the number of feature combinations the CI tests with 35%. |
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope that at some point we add support for parsing different locales (should not be all that hard). And that we can make the new formatting API work without
alloc(proven to be possible in #1163).In both cases it does not make much sense for the
unstable-localesfeature to imply theallocfeature.This will break uses of chrono with
no-default-featureswith theunstable-localesfeature, that happen to also depend onalloc.I feel we are allowed to make this change because of the name unstable-locales.
Split out from #1163.