Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: chromium/chromium
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 86.0.4240.73
Choose a base ref
...
head repository: chromium/chromium
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 86.0.4240.75
Choose a head ref
  • 10 commits
  • 14 files changed
  • 4 contributors

Commits on Oct 4, 2020

  1. Roll ChromeOS Orderfiles from 86-4240.49-1601290298-benchmark-86.0.42…

    …40.70-r1 to 86-4240.49-1601290298-benchmark-86.0.4240.72-r1
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/cros-orderfile-chromium-beta
    Please CC [email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
    
    Tbr: [email protected]
    Change-Id: I9e568c172391139d75420381ce2184693326914e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448427
    Reviewed-by: Chrome Release Autoroll <[email protected]>
    Cr-Commit-Position: refs/branch-heads/4240@{#1141}
    Cr-Branched-From: f297677-refs/heads/master@{#800218}
    Chrome Release Autoroll
    Chrome Release Autoroll committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    fea94cb View commit details
    Browse the repository at this point in the history
  2. Roll ChromeOS Silvermont AFDO profile from 86-4240.49-1601290298-benc…

    …hmark-86.0.4240.72-r1 to 86-4240.49-1601290298-benchmark-86.0.4240.73-r1
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
    Please CC [email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
    
    Tbr: [email protected]
    Change-Id: Ib5554140006bb8c846ce908b5998d740f3a2a28a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448598
    Reviewed-by: Chrome Release Autoroll <[email protected]>
    Commit-Queue: Chrome Release Autoroll <[email protected]>
    Cr-Commit-Position: refs/branch-heads/4240@{#1142}
    Cr-Branched-From: f297677-refs/heads/master@{#800218}
    Chrome Release Autoroll Commit Bot
    Chrome Release Autoroll authored and Commit Bot committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    c171e22 View commit details
    Browse the repository at this point in the history
  3. Roll ChromeOS Broadwell AFDO profile from 86-4240.49-1601291717-bench…

    …mark-86.0.4240.72-r1 to 86-4240.49-1601291717-benchmark-86.0.4240.73-r1
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
    Please CC [email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
    
    Tbr: [email protected]
    Change-Id: Ib61d4d0488d420ac5856410be2a512a8200b94c6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448601
    Reviewed-by: Chrome Release Autoroll <[email protected]>
    Commit-Queue: Chrome Release Autoroll <[email protected]>
    Cr-Commit-Position: refs/branch-heads/4240@{#1143}
    Cr-Branched-From: f297677-refs/heads/master@{#800218}
    Chrome Release Autoroll Commit Bot
    Chrome Release Autoroll authored and Commit Bot committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    b9090e3 View commit details
    Browse the repository at this point in the history
  4. Roll ChromeOS Airmont AFDO profile from 86-4240.49-1601287891-benchma…

    …rk-86.0.4240.72-r1 to 86-4240.49-1601287891-benchmark-86.0.4240.73-r1
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
    Please CC [email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
    
    Tbr: [email protected]
    Change-Id: Ibf27f7b7895d75da4941a39d1bec928b0d2ddf23
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448599
    Reviewed-by: Chrome Release Autoroll <[email protected]>
    Commit-Queue: Chrome Release Autoroll <[email protected]>
    Cr-Commit-Position: refs/branch-heads/4240@{#1144}
    Cr-Branched-From: f297677-refs/heads/master@{#800218}
    Chrome Release Autoroll Commit Bot
    Chrome Release Autoroll authored and Commit Bot committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    344b593 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Incrementing VERSION to 86.0.4240.74

    [email protected]
    
    Change-Id: I6f4ce43f09136c9ec0941b377d2793655ffbc8a4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448673
    Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/branch-heads/4240@{#1145}
    Cr-Branched-From: f297677-refs/heads/master@{#800218}
    chrome-release-bot Chrome Release Bot (LUCI)
    chrome-release-bot authored and Chrome Release Bot (LUCI) committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    23fd76a View commit details
    Browse the repository at this point in the history
  2. [iOS] Fixing a crash in AutofillAgent blocks.

    Adding a check for _suggestionHandledCompletion in a block prior to
    calling it.
    
    (cherry picked from commit 98ac45f)
    
    Bug: 1134005
    Change-Id: I8a8fae7abe4567925514bd98841d5866f70c2dab
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445010
    Reviewed-by: Olivier Robin <[email protected]>
    Reviewed-by: Dominic Battré <[email protected]>
    Commit-Queue: Maria Kazinova <[email protected]>
    Cr-Original-Commit-Position: refs/heads/master@{#813255}
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449336
    Commit-Queue: Olivier Robin <[email protected]>
    Cr-Commit-Position: refs/branch-heads/4240@{#1146}
    Cr-Branched-From: f297677-refs/heads/master@{#800218}
    Maria Kazinova Commit Bot
    Maria Kazinova authored and Commit Bot committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    50e3dbc View commit details
    Browse the repository at this point in the history
  3. Roll ChromeOS Orderfiles from 86-4240.49-1601290298-benchmark-86.0.42…

    …40.72-r1 to 86-4240.49-1601290298-benchmark-86.0.4240.73-r1
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/cros-orderfile-chromium-beta
    Please CC [email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
    
    Tbr: [email protected]
    Change-Id: I36bc76299694542339b90caba87331e35ab24dfb
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450469
    Reviewed-by: Chrome Release Autoroll <[email protected]>
    Cr-Commit-Position: refs/branch-heads/4240@{#1147}
    Cr-Branched-From: f297677-refs/heads/master@{#800218}
    Chrome Release Autoroll
    Chrome Release Autoroll committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    0ac42c4 View commit details
    Browse the repository at this point in the history
  4. Revert "Add callback to WebMediaPlayerImpl to notify when a redirect …

    …occurs"
    
    This reverts commit 88f263f.
    
    Reason for revert: Breaks played out audio too.
    
    Original change's description:
    > Add callback to WebMediaPlayerImpl to notify when a redirect occurs
    >
    > (cherry picked from commit 8b18bcf)
    >
    > Bug: 1128657
    > Change-Id: I9548e1f3bfe5693871a56e23c3373f45147e52e0
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422091
    > Reviewed-by: Dale Curtis <[email protected]>
    > Reviewed-by: Guido Urdaneta <[email protected]>
    > Commit-Queue: Guido Urdaneta <[email protected]>
    > Cr-Original-Commit-Position: refs/heads/master@{#809217}
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425223
    > Commit-Queue: Will Cassella <[email protected]>
    > Cr-Commit-Position: refs/branch-heads/4240@{#993}
    > Cr-Branched-From: f297677-refs/heads/master@{#800218}
    
    [email protected],[email protected],[email protected]
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1128657
    Change-Id: I0b2264a4078059a4aebd8117446e112565994f49
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450349
    Reviewed-by: Dale Curtis <[email protected]>
    Reviewed-by: Guido Urdaneta <[email protected]>
    Commit-Queue: Dale Curtis <[email protected]>
    Cr-Commit-Position: refs/branch-heads/4240@{#1148}
    Cr-Branched-From: f297677-refs/heads/master@{#800218}
    dalecurtis authored and Commit Bot committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    bc58153 View commit details
    Browse the repository at this point in the history
  5. Incrementing VERSION to 86.0.4240.75

    [email protected]
    
    Change-Id: I794ba660e7945da5eb8cea92760edd9993a9de69
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449914
    Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/branch-heads/4240@{#1149}
    Cr-Branched-From: f297677-refs/heads/master@{#800218}
    chrome-release-bot Chrome Release Bot (LUCI)
    chrome-release-bot authored and Chrome Release Bot (LUCI) committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    c69c339 View commit details
    Browse the repository at this point in the history
  6. Publish DEPS for 86.0.4240.75

    chrome-release-bot
    chrome-release-bot committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    791b88f View commit details
    Browse the repository at this point in the history
Loading