[ENH] Delete with limit in server by Sicheng-Pan · Pull Request #6573 · chroma-core/chroma

Sicheng-Pan · 2026-03-06T23:18:54Z

Description of changes

Summarize the changes made by this PR.

Improvements & Bug fixes
- N/A
New functionality
- Introduce limit: Option<u32> in the collection delete route. The response now returns how many records have been deleted.

Test plan

How are these changes tested?

Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

github-actions · 2026-03-06T23:19:07Z

Sicheng-Pan · 2026-03-06T23:19:08Z

[ENH] Delete with limit in clients #6578
[ENH] Delete with limit in server #6573 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

propel-code-bot

Changes suggested to add validation, correct API docs, and expose new delete limit in bindings.

Status: Changes Suggested | Risk: Medium

Issues Identified & Suggestions

Validate delete limit bounds to avoid no-op/exhaustion: rust/types/src/api_types.rs
Fix OpenAPI response type for delete endpoint: rust/frontend/src/server.rs
Expose limit and deleted count in Python bindings: rust/python_bindings/src/bindings.rs

Review Details

📁 9 files reviewed | 💬 3 comments

👍 / 👎 individual comments to help improve reviews for you

propel-code-bot · 2026-03-06T23:59:02Z

rust/types/src/api_types.rs

        collection_id: CollectionUuid,
        ids: Option<Vec<String>>,
        r#where: Option<Where>,
+        limit: Option<u32>,


[Security] Missing validation: The limit parameter is accepted as Option<u32> but lacks validation for sensible bounds. A client could send limit: 0 or limit: u32::MAX, both of which are problematic.

Issues:

limit: 0 makes the operation a no-op (why allow it?)

limit: u32::MAX (4.2 billion) could cause memory exhaustion

No documented maximum safe value

Fix: Add validation in try_new():

if let Some(limit_val) = limit { if limit_val == 0 { return Err(ChromaValidationError::from(( "limit", "must be greater than 0", ))); } if limit_val > MAX_DELETE_LIMIT { // e.g., 10000 return Err(ChromaValidationError::from(( "limit", format!("must not exceed {}", MAX_DELETE_LIMIT), ))); } }

Context for Agents

**Missing validation**: The `limit` parameter is accepted as `Option<u32>` but lacks validation for sensible bounds. A client could send `limit: 0` or `limit: u32::MAX`, both of which are problematic. **Issues**: - `limit: 0` makes the operation a no-op (why allow it?) - `limit: u32::MAX` (4.2 billion) could cause memory exhaustion - No documented maximum safe value **Fix**: Add validation in `try_new()`: ```rust if let Some(limit_val) = limit { if limit_val == 0 { return Err(ChromaValidationError::from(( "limit", "must be greater than 0", ))); } if limit_val > MAX_DELETE_LIMIT { // e.g., 10000 return Err(ChromaValidationError::from(( "limit", format!("must not exceed {}", MAX_DELETE_LIMIT), ))); } } ``` File: rust/types/src/api_types.rs Line: 1580

For backward compact we need to support None, which is equivalent to u32::MAX. Limit by itself is not going to introduce additional cost than what we already have

rust/frontend/src/server.rs

propel-code-bot · 2026-03-06T23:59:02Z

rust/python_bindings/src/bindings.rs

            collection_id,
            ids,
            r#where,
+            None,


[Requirements] The limit parameter is hardcoded to None here, meaning the new functionality is not exposed to Python users. Additionally, the return value (deleted count) is discarded by returning Ok(()).

Please update the delete method signature to accept an optional limit argument and return the deleted count, ensuring feature parity for the Python bindings.

Context for Agents

The `limit` parameter is hardcoded to `None` here, meaning the new functionality is not exposed to Python users. Additionally, the return value (deleted count) is discarded by returning `Ok(())`. Please update the `delete` method signature to accept an optional `limit` argument and return the deleted count, ensuring feature parity for the Python bindings. File: rust/python_bindings/src/bindings.rs Line: 577

Will be resolved in next PR on stack

propel-code-bot · 2026-03-07T01:39:01Z

Add delete limits with deleted-count responses across API and frontends

This PR introduces a limit parameter for collection record deletion and returns a deleted-count in responses. Core request/response types were updated to include limit and deleted, and deletion logic now applies limits when a where clause is present while rejecting limit without a filter.

Server handlers, service-based and in-memory frontends, and generated JS client types were updated to surface the new payload/response shape, and extensive Rust tests were added to validate limit behavior across where/ids scenarios and looped deletions.

This summary was automatically generated by @propel-code-bot

HammadB · 2026-03-07T01:50:13Z

rust/frontend/src/impls/service_based_frontend.rs

                encoding: None,
                metadata: None,
            }));
+            if let Some(limit) = limit {


can we just error if user ids len > limit??

limit is relevant only when a where is specified. added validation for this

HammadB · 2026-03-07T01:52:05Z

rust/frontend/tests/test_delete_limit.rs

+    assert_eq!(count(&mut frontend, &collection).await, 2);
+
+    // Limit is 100, but only 2 records match.
+    let response = frontend


can we add a test that loops over batches to use this correctly?

HammadB · 2026-03-07T01:53:18Z

rust/types/src/api_types.rs

 #[cfg_attr(feature = "utoipa", derive(utoipa::ToSchema))]
 pub struct DeleteCollectionRecordsPayload {
    pub ids: Option<Vec<String>>,
+    pub limit: Option<u32>,


I think you need a default here to be b/w compatible

added serde default

propel-code-bot

Review found no issues; changes appear solid and well-covered by tests.

Status: No Issues Found | Risk: Low

Review Details

📁 10 files reviewed | 💬 0 comments

## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - N/A - New functionality - Introduce `limit: Option<u32>` in the collection delete route. The response now returns how many records have been deleted. ## Test plan _How are these changes tested?_ - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Migration plan _Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?_ ## Observability plan _What is the plan to instrument and monitor this change?_ ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_

This PR cherry-picks the commit 9100022 onto release/2026-02-20. If there are unresolved conflicts, please resolve them manually. Co-authored-by: Macronova <[email protected]>

This PR cherry-picks the commit 9100022 onto rc/2026-03-06. If there are unresolved conflicts, please resolve them manually. Co-authored-by: Macronova <[email protected]>

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

Sicheng-Pan force-pushed the 03-06-_enh_delete_with_limit branch 2 times, most recently from 19c9b46 to b5e2b71 Compare March 6, 2026 23:30

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

Sicheng-Pan force-pushed the 03-06-_enh_delete_with_limit branch from b5e2b71 to 2755df3 Compare March 6, 2026 23:54

propel-code-bot bot reviewed Mar 6, 2026

View reviewed changes

Sicheng-Pan force-pushed the 03-06-_enh_delete_with_limit branch from 2755df3 to c0b3443 Compare March 7, 2026 00:03

This comment was marked as outdated.

Sign in to view

[ENH] Delete with limit

b5fcebe

Sicheng-Pan force-pushed the 03-06-_enh_delete_with_limit branch from c0b3443 to dab3721 Compare March 7, 2026 00:44

Test

861f644

Sicheng-Pan force-pushed the 03-06-_enh_delete_with_limit branch from dab3721 to 861f644 Compare March 7, 2026 01:36

Sicheng-Pan marked this pull request as ready for review March 7, 2026 01:38

Sicheng-Pan requested a review from rescrv as a code owner March 7, 2026 01:38

This comment was marked as outdated.

Sign in to view

HammadB reviewed Mar 7, 2026

View reviewed changes

HammadB approved these changes Mar 7, 2026

View reviewed changes

Sicheng-Pan force-pushed the 03-06-_enh_delete_with_limit branch from 045a146 to 0ce6340 Compare March 7, 2026 02:37

This comment was marked as outdated.

Sign in to view

Sicheng-Pan force-pushed the 03-06-_enh_delete_with_limit branch from 0ce6340 to 1d4a302 Compare March 7, 2026 02:50

propel-code-bot bot reviewed Mar 7, 2026

View reviewed changes

Address comments

0e11fca

Sicheng-Pan force-pushed the 03-06-_enh_delete_with_limit branch from 1d4a302 to 0e11fca Compare March 7, 2026 02:58

Sicheng-Pan changed the title ~~[ENH] Delete with limit~~ [ENH] Delete with limit in server Mar 7, 2026

Sicheng-Pan mentioned this pull request Mar 7, 2026

[ENH] Delete with limit in clients #6578

Merged

1 task

Sicheng-Pan merged commit 9100022 into main Mar 7, 2026
108 of 131 checks passed

tazarov mentioned this pull request Mar 7, 2026

Delete with limit amikos-tech/chroma-go#439

Open

tazarov mentioned this pull request Mar 8, 2026

Support Chroma 1.5.3 delete with limit amikos-tech/chroma-go-local#59

Closed

Conversation

Sicheng-Pan commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Test plan

Migration plan

Observability plan

Documentation Changes

Uh oh!

github-actions bot commented Mar 6, 2026

Reviewer Checklist

Testing, Bugs, Errors, Logs, Documentation

System Compatibility

Quality

Uh oh!

Sicheng-Pan commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

Uh oh!

This comment has been minimized.

propel-code-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

propel-code-bot bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

propel-code-bot bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

propel-code-bot bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

propel-code-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sicheng-Pan commented Mar 6, 2026 •

edited

Loading

Sicheng-Pan commented Mar 6, 2026 •

edited

Loading

propel-code-bot bot commented Mar 7, 2026 •

edited

Loading