Skip to content

[ENH] Pplx EF#6511

Merged
itaismith merged 3 commits intomainfrom
itai/pplx-efs
Feb 27, 2026
Merged

[ENH] Pplx EF#6511
itaismith merged 3 commits intomainfrom
itai/pplx-efs

Conversation

@itaismith
Copy link
Copy Markdown
Contributor

@itaismith itaismith commented Feb 27, 2026

Adding Pplx EFs

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 27, 2026

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Copy Markdown
Contributor

propel-code-bot bot commented Feb 27, 2026 •
edited
Loading

Add Perplexity embedding functions and documentation

This PR introduces Perplexity embedding function support across the TypeScript client packages and the Python SDK, including a new @chroma-core/perplexity package, Perplexity client integration, and configuration schema. It also registers the new embedding function in the Python registry and updates shared utilities for base64 decoding of embeddings.

Documentation is expanded with a new Perplexity integration page, updates to embedding-function listings, and navigation updates. Lockfile changes include the new dependency @perplexity-ai/perplexity_ai and an update to chromadb-js-bindings versions in clients/new-js/pnpm-lock.yaml.

Key Changes

• Added PerplexityEmbeddingFunction implementation and registration in clients/new-js/packages/ai-embeddings/perplexity/src/index.ts and chromadb/utils/embedding_functions/perplexity_embedding_function.py
• Introduced new Perplexity config schema in schemas/embedding_functions/perplexity.json and wired it into clients/new-js/packages/ai-embeddings/common/src/schema-utils.ts
• Added base64 embedding decode helpers in clients/new-js/packages/ai-embeddings/common/src/index.ts and chromadb/utils/embedding_functions/utils.py
• Added Perplexity docs and navigation updates in docs/mintlify/integrations/embedding-models/perplexity.mdx, docs/mintlify/docs/embeddings/embedding-functions.mdx, and docs/mintlify/docs.json
• Created package scaffolding, build config, and tests for @chroma-core/perplexity in clients/new-js/packages/ai-embeddings/perplexity/

Possible Issues

• TypeScript decodeBase64Embedding returns an Int8Array-derived number[] without explicit conversion to float; confirm this matches expected embedding representation in downstream consumers.
• Ensure mint validate is run so docs.json references and new Perplexity docs stay in sync.
• Lockfile updates include chromadb-js-bindings version changes; confirm this is intentional and not an unintended upgrade.

This summary was automatically generated by @propel-code-bot

propel-code-bot[bot]

This comment was marked as outdated.

Sign in to view

@tazarov tazarov mentioned this pull request Feb 27, 2026
Closed
@blacksmith-sh

This comment has been minimized.

Sign in to view
propel-code-bot[bot]
propel-code-bot bot reviewed Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@propel-code-bot propel-code-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change to honor user-provided API key environment variable over default overrides.

Status: Changes Suggested | Risk: Medium

Issues Identified & Suggestions
  • Respect passed api_key_env_var instead of overriding when default exists: perplexity_embedding_function.py
Review Details

📁 19 files reviewed | 💬 1 comments

Instruction Files 
└── docs/
    └── mintlify/
        ├── AGENTS.md
        └── CLAUDE.md

👍 / 👎 individual comments to help improve reviews for you

@itaismith itaismith merged commit 517c6a8 into main Feb 27, 2026
129 of 131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@propel-code-bot propel-code-bot[bot] propel-code-bot[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@itaismith