[CHORE](k8s) increase dev CPU limits from 100m to 200-300m#6435
Conversation
Raise CPU resource limits and requests from 100m to 500m for all services in both values.dev.yaml and values2.dev.yaml. The previous 100m limits were too restrictive for dev workloads, causing CPU throttling. Affected services: sysdb, rustFrontendService, queryService, compactionService, rustLogService, garbageCollector, rustSysdbService, and rustSysdbMigration. Co-authored-by: AI
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
|
|
I believe this change fixes what was responsible for the garbage_collector_component::tests::test_k8s_integration_tenant_mode_override test failures in CI. |
|
Updates the dev Helm values used in CI so each service now requests and limits 200m CPU instead of the previous 100m, ensuring throttled pods receive sufficient headroom. Possible Issues• Mismatch between PR description/review feedback (300m) and final values (200m) could leave query workloads under-provisioned. This summary was automatically generated by @propel-code-bot |
This comment has been minimized.
This comment has been minimized.
rescrv
changed the title
rescrv
changed the title
![propel-code-bot[bot]](https://avatars.githubusercontent.com/in/1179004?s=60&v=4){kind=small}
| resources: | ||
| limits: | ||
| cpu: 100m | ||
| cpu: 200m |
There was a problem hiding this comment.
[Requirements] QueryService is still capped at 200m here (and in values2.dev.yaml), even though the PR description says every service should move to 300m to eliminate throttling. Leaving this service at 200m keeps the query pods under-provisioned while everything else gets the higher limit/request. Please bump both the limits and requests CPU values for QueryService to 300m in both dev values files, e.g.
resources:
limits:
cpu: 300m
requests:
cpu: 300mContext for Agents
QueryService is still capped at 200m here (and in `values2.dev.yaml`), even though the PR description says every service should move to 300m to eliminate throttling. Leaving this service at 200m keeps the query pods under-provisioned while everything else gets the higher limit/request. Please bump both the `limits` and `requests` CPU values for QueryService to 300m in both dev values files, e.g.
```yaml
resources:
limits:
cpu: 300m
requests:
cpu: 300m
```
File: k8s/distributed-chroma/values.dev.yaml
Line: 38| cpu: 200m | ||
| requests: | ||
| cpu: 100m | ||
| cpu: 200m |
There was a problem hiding this comment.
[Requirements] The PR description mentions that rustSysdbService and rustSysdbMigration are updated in both values files. However, the updates for these services appear to be missing from this file (they are correctly updated in k8s/distributed-chroma/values2.dev.yaml).
Context for Agents
The PR description mentions that `rustSysdbService` and `rustSysdbMigration` are updated in both values files. However, the updates for these services appear to be missing from this file (they are correctly updated in `k8s/distributed-chroma/values2.dev.yaml`).
File: k8s/distributed-chroma/values.dev.yaml
Line: 67
- **[ENH]: Cache rust git submodules in mounted volume (#6424)** - **[CHORE](k8s) increase dev CPU limits from 100m to 200-300m (#6435)** - **[ENH] replace live cloud tests with k8s integration tests (#6434)** - **[ENH] Make dirty_log_collections metric mcmr-aware. (#6353)** - **[ENH] Quantized Spann Segment Writer (#6397)** - **[ENH] Wire up quantized writer in compaction (#6399)** - **[ENH] Quantized Spann Segment Reader (#6405)** - **[ENH] Wire up quantized reader in new orchestrator (#6409)** - **[ENH] Garbage collect usearch index files (#6416)** - **[ENH] Trace quantized spann implementation (#6425)** - **[ENH]: Precompute data chunk len() (#6442)** - **[BUG]: Compaction version file flush was incomplete on MCMR (#6423)** - **[DOC]: Fixed broken links in Readme (#6440)** - **[DOC] Fix link to Rust documentation (#6443)** - **[ENH]: Allow users to disable FTS in schema (#6214)** --------- Co-authored-by: Robert Escriva <[email protected]> Co-authored-by: Macronova <[email protected]> Co-authored-by: Nilpotent <[email protected]> Co-authored-by: anderk222 <[email protected]> Co-authored-by: Sanket Kedia <[email protected]>
2 participants
Description of changes
Raise CPU resource limits and requests from 100m to 300m for all
services in both values.dev.yaml and values2.dev.yaml. The previous
100m limits were too restrictive for dev workloads, causing CPU
throttling.
Affected services: sysdb, rustFrontendService, queryService,
compactionService, rustLogService, garbageCollector, rustSysdbService,
and rustSysdbMigration.
Test plan
CI
Migration plan
N/A
Observability plan
CI goes green
Documentation Changes
N/A
Co-authored-by: AI