[ENH] reject fork_collection for multi-region databases#6400
Merged
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
rescrv
changed the title
Contributor
|
The integration test now drives the HTTP fork_collection endpoint end to end, confirming that topology-prefixed database requests receive a 400 BAD_REQUEST with the expected InvalidArgument error payload. Possible Issues• Debug This summary was automatically generated by @propel-code-bot |
rescrv
force-pushed
the
rescrv/no-topo-fork
branch
from
0af14fc to
9d33737
Compare
![propel-code-bot[bot]](https://avatars.githubusercontent.com/in/1179004?s=60&v=4){kind=small}
Comment on lines
+3441
to
+3446
| assert_eq!( | ||
| response_json["error"], | ||
| serde_json::Value::String("InvalidArgumentError".to_string()), | ||
| ); | ||
| println!("response_json: {:?}", response_json); | ||
| assert!( |
Contributor
There was a problem hiding this comment.
[Style] Remove the debug println! statement from the test code. It creates unnecessary noise in the test output.
Context for Agents
Remove the debug `println!` statement from the test code. It creates unnecessary noise in the test output.
File: rust/frontend/src/server.rs
Line: 3446
This comment has been minimized.
This comment has been minimized.
tanujnay112
approved these changes
Feb 11, 2026
| }, | ||
| ) | ||
| .await?; | ||
| let database_name = DatabaseName::new(&database).ok_or_else(|| { |
Contributor
There was a problem hiding this comment.
Would be good to make a helper method for this that we can easily use on other unimplemented for MCMR features.
Contributor
Author
There was a problem hiding this comment.
What would the method do? You'd need to make the error universally returnable.
rescrv
force-pushed
the
rescrv/no-topo-fork
branch
from
9d33737 to
6ff73ed
Compare
Multi-region databases (those with a topology prefix in their name) do not support collection forking. Add a validation check early in the fork_collection handler to return an InvalidArgumentError before proceeding with the operation. Include a test that exercises the rejection path by sending a fork request with a topology-prefixed database name. Co-authored-by: AI
rescrv
force-pushed
the
rescrv/no-topo-fork
branch
from
6ff73ed to
22f8357
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: propel-code-bot[bot] <203372662+propel-code-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Multi-region databases (those with a topology prefix in their name) do
not support collection forking. Add a validation check early in the
fork_collection handler to return an InvalidArgumentError before
proceeding with the operation.
Include a test that exercises the rejection path by sending a fork
request with a topology-prefixed database name.
Test plan
Locally the new test passes; CI for the rest.
Migration plan
N/A
Observability plan
N/A
Documentation Changes
N/A
Co-authored-by: AI