Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@basnijholt - thank you!

Maintainers: Would be great if you could merge this important fix! :-)

The v2 for Pydantic and also Pydantic-settings was released in June 2023, hopefully an acceptable version bump for you.

@HammadB, just to make it obvious–currently at least 1000 downstream dependencies of ChromaDB cannot support Python 3.14 because this simple problem.

In my own library that uses ChromaDB, I have to jump through insane runtime monkeypatching to get it to work (basnijholt/agent-cli@6f868f5).

I am confident that almost all developers would value supporting new Python versions over backward compatibility with pydantic v1.

9 out of 10 major chromadb dependents already require pydantic v2 (directly or transitively), so the v1 compat layer serves essentially no one:

The only holdout is chromadb-client — chromadb's own package.

"""Check whether major chromadb dependents already require pydantic v2."""
import json, re, urllib.request

def get_requires_dist(pkg):
    try:
        url = f"https://pypi.org/pypi/{pkg}/json"
        req = urllib.request.Request(url, headers={"User-Agent": "Mozilla/5.0"})
        with urllib.request.urlopen(req, timeout=10) as resp:
            data = json.loads(resp.read())
        return data.get("info", {}).get("requires_dist") or []
    except Exception:
        return []

def find_pydantic_v2_req(pkg, depth=0, visited=None):
    if visited is None:
        visited = set()
    if pkg in visited or depth > 2:
        return None
    visited.add(pkg)
    for dep in get_requires_dist(pkg):
        dep_clean = re.split(r"\s*;", dep)[0].strip()
        dep_name = re.split(r"[\s>=<\[!]", dep_clean)[0].lower()
        if dep_name == "pydantic" and re.search(r">=\s*2", dep):
            return (pkg if depth > 0 else "direct", dep_clean)
        if depth < 1 and dep_name not in visited:
            result = find_pydantic_v2_req(dep_name, depth + 1, visited)
            if result:
                return result
    return None

for pkg in [
    "langchain-chroma", "llama-index-vector-stores-chroma",
    "crewai", "embedchain", "semantic-kernel", "mem0ai",
    "superagi", "llmware", "langflow", "chromadb-client",
]:
    result = find_pydantic_v2_req(pkg)
    if result:
        via, constraint = result
        print(f"{pkg}: requires pydantic v2 (via {via}) — {constraint}")
    else:
        print(f"{pkg}: does NOT require pydantic v2")

+1

This also updates dependency constraints across server and client packaging to require pydantic v2 and pydantic-settings.

This summary was automatically generated by @propel-code-bot

@kylediaz I pushed a follow-up fix for the remaining Python 3.14 test failure in this PR (808c452).

I fixed chromadb/test/property/test_cross_version_persist.py so it skips historical chromadb versions that cannot import on Python 3.14 due to pydantic.v1 incompatibility (chroma_server_nofile ConfigError), while still running cross-version coverage for supported versions.

I verified locally with:

• pytest chromadb/test/property/test_cross_version_persist.py
• CHROMA_RUST_BINDINGS_TEST_ONLY=1 pytest chromadb/test/property/test_cross_version_persist.py (after building/installing the wheel)

This should unblock the 3.14 cross-version CI path from our side. Is there anything else you want me to do to get this merged?

Hey @basnijholt
thank you for helping us with this! sorry for messing up your branch there for a bit. I tested it and I approve of your changes, but I'm going to get further review first before we merge.
don't worry about the gcs test. we expect it to fail for you -- external contributors don't have the correct credentials. we'll merge it anyway.

Great!

You only lost this commit on the force push 808c452.

your PR was good as-is. It will fail if we add python 3.14, but that is not because of your code, it's because of how test_cross_version_compat works. this test verifies migrations across chroma versions work. it will fetch the latest release from pypi, but the latest release is clearly in a broken state. rather than you needing to fix the test, we need to fix the package. sorry about this.

@basnijholt thanks! we're going to make a release for this fix ASAP

@kylediaz I ran into a small issue with this change now. I opened a followup here #6535.

The test shows what currently fails on main.