[ENH]: Allow users to disable FTS in schema#6214
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Schema builders across the Rust storage layer, Python server, and JS client now enforce the FTS-only-on- Affected Areas• rust/segment/src/blockfile_metadata.rs This summary was automatically generated by @propel-code-bot |
This comment has been minimized.
This comment has been minimized.
## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - Apply materialized logs skips fts indexing if disabled in schema. Note that it would still flush one empty block and a sparse index with one entry (init state) and write this file path to sysdb. Chose this approach for simplicity and due to less changes. Ideally the file path should be absent in sysdb for fts, the writer/reader should not create fts, etc. - Query/Get/Search throws an error if user tries FTS/Regex in such a case - Rust client, Python client and JS client now allow setting this. Previously the user would get an error if they try to disable FTS - New functionality - ... ## Test plan _How are these changes tested?_ Added unit tests and e2e tests - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Migration plan None ## Observability plan None ## Documentation Changes None
- **[ENH]: Cache rust git submodules in mounted volume (#6424)** - **[CHORE](k8s) increase dev CPU limits from 100m to 200-300m (#6435)** - **[ENH] replace live cloud tests with k8s integration tests (#6434)** - **[ENH] Make dirty_log_collections metric mcmr-aware. (#6353)** - **[ENH] Quantized Spann Segment Writer (#6397)** - **[ENH] Wire up quantized writer in compaction (#6399)** - **[ENH] Quantized Spann Segment Reader (#6405)** - **[ENH] Wire up quantized reader in new orchestrator (#6409)** - **[ENH] Garbage collect usearch index files (#6416)** - **[ENH] Trace quantized spann implementation (#6425)** - **[ENH]: Precompute data chunk len() (#6442)** - **[BUG]: Compaction version file flush was incomplete on MCMR (#6423)** - **[DOC]: Fixed broken links in Readme (#6440)** - **[DOC] Fix link to Rust documentation (#6443)** - **[ENH]: Allow users to disable FTS in schema (#6214)** --------- Co-authored-by: Robert Escriva <[email protected]> Co-authored-by: Macronova <[email protected]> Co-authored-by: Nilpotent <[email protected]> Co-authored-by: anderk222 <[email protected]> Co-authored-by: Sanket Kedia <[email protected]>

Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
Added unit tests and e2e tests
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
None
Observability plan
None
Documentation Changes
None