Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
Implement collection update workflow across API, backend, and schema layers Introduces end-to-end support for Key Changes• Added Affected Areas• This summary was automatically generated by @propel-code-bot |
![propel-code-bot[bot]](https://avatars.githubusercontent.com/in/1179004?s=60&v=4){kind=small}
| /// - `dimension`: New dimension value | ||
| /// - `metadata`: New metadata (replaces existing if provided) | ||
| /// - `reset_metadata`: If true, deletes all existing metadata | ||
| /// - `new_configuration`: New configuration (selective update of hnsw, spann, or embedding function) |
There was a problem hiding this comment.
what about schema_str? would need to update that during compactions
There was a problem hiding this comment.
yeah, I am doing only the user facing update. Later this should be modified to account for all internal updates also such as schema, segment file paths, etc
This comment has been minimized.
This comment has been minimized.
| .await; | ||
|
|
||
| // Update spann config | ||
| let spann_update = chroma_types::UpdateSpannConfiguration { |
There was a problem hiding this comment.
we should separate out the tests sometime, this file is huge now
There was a problem hiding this comment.
yea, will do next week
| // Update Operations | ||
| // ============================================================ | ||
|
|
||
| /// Update a collection. |
There was a problem hiding this comment.
i take it there's no reason to have a batch API for this? Could be beneficial for GC?
There was a problem hiding this comment.
will modify when needed. Will have to read GC code
2 participants
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
Added tests
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
None
Observability plan
None
Documentation Changes
None