Skip to content

[ENH] Export search options parameter#6160

Merged
gshahbazian merged 2 commits intomainfrom
gabe/export-search-options
Jan 14, 2026
Merged

[ENH] Export search options parameter#6160
gshahbazian merged 2 commits intomainfrom
gabe/export-search-options

Conversation

@gshahbazian
Copy link
Copy Markdown
Contributor

Also ran prettier which formatted a bunch of random files

@gshahbazian gshahbazian requested a review from itaismith January 14, 2026 18:29
@github-actions
Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Copy Markdown
Contributor

propel-code-bot bot commented Jan 14, 2026

Expose search read-level option in JS client

Extends the JavaScript collection search API to accept a readLevel option that controls whether queries hit the write-ahead log, and plumbs this setting through to the service payload. The change introduces a typed ReadLevel constant for consumers, updates the collection contract, and adds regression tests that confirm the option is serialized onto outgoing requests while keeping existing behaviour untouched.

Key Changes

• Updated Collection.search overload in clients/new-js/packages/chromadb/src/collection.ts to accept an optional { readLevel?: ReadLevel } argument and forward it as read_level in the API request body.
• Exposed ReadLevel enum-style constant in clients/new-js/packages/chromadb/src/types.ts for SDK users to specify index_and_wal or index_only.
• Added integration tests in clients/new-js/packages/chromadb/test/search.expression.test.ts ensuring readLevel is honored and defaults remain unchanged.
• Bumped optional native binding dependencies in clients/new-js/pnpm-lock.yaml to version 1.2.1 (and pulled through ts-jest’s new esbuild peer) while running Prettier across affected sources.

Affected Areas

clients/new-js/packages/chromadb/src/collection.ts
clients/new-js/packages/chromadb/src/types.ts
clients/new-js/packages/chromadb/test/search.expression.test.ts
clients/new-js/pnpm-lock.yaml

This summary was automatically generated by @propel-code-bot

@gshahbazian gshahbazian merged commit 70b5427 into main Jan 14, 2026
65 checks passed
@gshahbazian gshahbazian deleted the gabe/export-search-options branch January 30, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants