Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
HammadB
commented
Sep 22, 2023
| embedding_function: Optional[EmbeddingFunction] = ef.DefaultEmbeddingFunction(), | ||
| metadata: Optional[CollectionMetadata] = None, | ||
| ): | ||
| super().__init__(name=name, metadata=metadata, id=id) |
Collaborator
Author
There was a problem hiding this comment.
This fixes pydantic v2 because it needs attrs inited before it can assign to PrivateAttrs
Closed
atroyn
approved these changes
Sep 25, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #893
Summarize the changes made by this PR.
Test plan
Existing tests were run with the following configs
pytestfor python,yarn testfor jsDocumentation Changes
None required.