Repository navigation
fix(schedules): fill available panel height with jobs table - #467
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Schedule table container layout frontend/src/components/schedules/RepoSchedulesContent.tsx, frontend/src/components/schedules/ServerSchedulesContent.tsx |
The repository schedule view removes vertical scrolling from the outer jobs container and lets the bordered container fill available space. The server schedule view moves top padding to the flex container and makes the bordered table container fill available space and handle scrolling. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Merge Risk: 
f1254
-
The schedule table layout change is ready to merge with no identified material risk.
Pre-merge checks: 
-
Check name Status Explanation Title check The title names the main change: the schedules jobs table now fills the available panel height. It follows the conventional commit format and is specific, short, and free of file lists or vague terms. Description check The description follows the template's Summary section and gives a clear root cause, the fix, and the affected components. Validation steps are reported. The Type of Change and Checklist sections are … Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description follows the template's Summary section and gives a clear root cause, the fix, and the affected components. Validation steps are reported. The Type of Change and Checklist sections are absent, so the author did not mark the bug fix type or the checklist items (style, types, tests, lint, typecheck). Lint is reported only for lint:frontend, not for the pnpm lint and pnpm typecheck commands the checklist names. The description is mostly complete, so the check passes.
Resolution
Optional: add the Type of Change selection (Bug fix) and mark the checklist items, or state whether pnpm lint and pnpm typecheck were run, since the template names those commands.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Summary
min-h-0but noflex-1, so it sized to its content. When the horizontal scrollbar appeared it stole height from that content-sized box, clipping the last row and adding a spurious vertical scrollbar.flex-1to fill the available height and owns both scroll axes; the redundant outeroverflow-y-autowas removed.RepoSchedulesContent) and the remote server schedules dialog (ServerSchedulesContent), which shared the same layout.Validation
pnpm lint:frontendpassesvitest run src/components/schedules: 16 files, 81 tests passSummary by CodeRabbit