Repository navigation
fix(notifications): phrase permission labels without losing acronyms - #466
Conversation
The always-allow summary interpolated the raw action id ("always allow
shell") while every other surface shows the label ("Run Command"), and
the permission dialog lowercased the whole label, turning "Fetch URL"
into "fetch url". getPermissionPhrase lowercases each word of the label
unless it is all caps, and both the scope summary and the dialog
question use it.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Format phrases and wildcard summaries shared/src/notifications/format.ts, backend/test/services/notification-format.test.ts |
The shared formatter lowercases non-uppercase words while preserving fully uppercase words. Wildcard summaries use the formatted phrase. Backend tests cover known labels, empty actions, unknown actions, and wildcard summary text. |
Use formatted phrases in permission prompts frontend/src/components/session/PermissionRequestDialog.tsx, frontend/src/components/session/PermissionRequestDialog.test.tsx |
The dialog question uses the shared formatter. Frontend tests check shell and webfetch wording and the wildcard scope text. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Merge Risk: 
8747c
-
The permission wording changes are mergeable with normal checks.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Title check The title names the main change: permission labels are phrased without losing acronyms, which matches the new getPermissionPhrase helper and the dialog/summary wording changes. It is specific, uses th… Description check The description covers the problem (raw action id in the wildcard always-allow summary and whole-label lowercasing in the PWA dialog), the change, tests, and validation results. It does not select a '… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the main change: permission labels are phrased without losing acronyms, which matches the new getPermissionPhrase helper and the dialog/summary wording changes. It is specific, uses the conventional commit prefix, and is 68 characters long.
Full details: Description check
-
Explanation
The description covers the problem (raw action id in the wildcard always-allow summary and whole-label lowercasing in the PWA dialog), the change, tests, and validation results. It does not select a 'Type of Change' box and does not tick the template checklist items, and it has no 'Summary' heading content beyond '## What'. The 'Code follows project style' and lint/typecheck items are partly reported in Validation, but the template checkboxes are unchecked. The core information is present, so the description is mostly complete.
-
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
What
Two wording bugs in permission prompts:
*scope interpolated the raw action id: "This will always allow shell for this project.", while the question above it says "Allow run command?".Change
shared/src/notifications/format.ts: newgetPermissionPhrase(action)lowercases each word ofgetPermissionLabel(action)unless the word is all caps ("Run Command" → "run command", "Fetch URL" → "fetch URL").getPermissionAlwaysScopeuses it for the wildcard summary ("This will always allow run command for this project.").frontend/src/components/session/PermissionRequestDialog.tsx: the question usesgetPermissionPhraseinstead oftypeLabel.toLowerCase(). This was the only whole-label lowercasing call site; the heading badge still shows the capitalized label.Tests
backend/test/services/notification-format.test.ts:getPermissionPhrasecases (multi-word, acronym, empty action, unknown action) and updated wildcard-scope expectations. The shared package has no test runner, and this file already covers the notification formatters.frontend/src/components/session/PermissionRequestDialog.test.tsx: updated wildcard summary and a phrasing test for "Allow run command?" / "Allow fetch URL?".Validation
pnpm --filter @opencode-manager/shared typecheck: cleanpnpm --filter backend exec vitest run test/services/notification-format.test.ts: 41 passedpnpm --filter frontend exec vitest run src/components/session src/components/navigation src/App.permission-dialog.test.tsx src/contexts/EventContext.test.tsx: 30 files, 618 tests passedpnpm --filter frontend typecheck: cleanFollow-up
The mobile app (ocmgr-mobile) carries a local copy of this phrasing helper until its
@opencode-manager/shareddependency is updated past this change; it will then switch togetPermissionPhraseand pick up the corrected scope summary.Summary by CodeRabbit