Repository navigation
test(e2e): clean up run artifacts after the suite - #422
Merged
Merged
Conversation
- server.sh removes e2e/.tmp when the backend exits, forwarding SIGTERM so Playwright's graceful shutdown still applies - a cleanup reporter removes playwright-report and test-results after a passing run; failed runs keep them for debugging and CI upload
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The artifact cleanup and backend shutdown changes are ready to merge; no actionable risk introduced by this PR remains. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description provides a detailed summary, affected files, and validation results. It omits the required "Type of Change" and "Checklist" sections from the repository template. | Add the "## Type of Change" section with the applicable checkbox selected, and add the complete "## Checklist" section with each required item marked or explained. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: cleaning up E2E run artifacts after the suite. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e/.tmpwhen the backend exits, and forward the shutdown signal so Playwright's graceful shutdown still applies. The cleanup lives inserver.shbecause Playwright's teardown hook runs before the server stops.playwright-report/andtest-results/after a passing run. Failed runs keep them for debugging and for the CI upload.e2e/env.tsand use them from the config and the reporter.Files
e2e/server.she2e/cleanup-reporter.ts(new)e2e/env.tse2e/playwright.config.tsValidation
e2e/.tmp,test-results/andplaywright-report/all removed afterwards, no server left listening on the e2e ports.test-results/andplaywright-report/kept,e2e/.tmpremoved.tsc --strict;pnpm lintreports 0 errors (41 pre-existing warnings).OpenCode server exited with code 130log line appears with the originalserver.shtoo, so it is pre-existing.Summary by CodeRabbit