Repository navigation
fix(navigation): scope the mobile Files tab to the assistant workspace - #393
Merged
Merged
Conversation
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the assistant route, the mobile Files tab opened the global workspace-root browser (every repo) instead of the assistant workspace.
/assistantthe tab bar treated only repo routes as scoped, so Files calledopen('files')and rendered the workspace root rather than the assistant directory.dialog=filesbrowser the assistant route already renders, matching the desktop sidebar and the More drawer./and/schedulesstill open the workspace root.Type of Change
Checklist
pnpm lintpasses locallypnpm typecheckpasses locallyFrontend typecheck is clean and eslint reports no errors on the frontend (one pre-existing warning in
ChangesWalkthroughDialog.tsx). Navigation tests pass (135 tests), including new cases asserting the assistant route opensdialog=filesand/opens the globalmobileTab=files. Verified in the running app at a 390px viewport: Files now opens the assistant workspace;/still opens the workspace root.Summary by CodeRabbit