Skip to content

fix(navigation): scope the mobile Files tab to the assistant workspace - #393

Merged
chriswritescode-dev merged 1 commit into
mainfrom
fix/assistant-mobile-files-tab
Oct 7, 2026
Merged

chriswritescode-dev merged 1 commit into
mainfrom
fix/assistant-mobile-files-tab

Conversation

@chriswritescode-dev

@chriswritescode-dev chriswritescode-dev commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

On the assistant route, the mobile Files tab opened the global workspace-root browser (every repo) instead of the assistant workspace.

  • On /assistant the tab bar treated only repo routes as scoped, so Files called open('files') and rendered the workspace root rather than the assistant directory.
  • The Files tab now treats the assistant route as scoped and opens the same dialog=files browser the assistant route already renders, matching the desktop sidebar and the More drawer.
  • Repo and global routes are unchanged: repo detail still opens its repo-scoped browser, and / and /schedules still open the workspace root.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation

Checklist

  • Code follows project style (no comments, named imports)
  • TypeScript types are properly defined
  • Tests added/updated (80% coverage target)
  • pnpm lint passes locally
  • pnpm typecheck passes locally

Frontend typecheck is clean and eslint reports no errors on the frontend (one pre-existing warning in ChangesWalkthroughDialog.tsx). Navigation tests pass (135 tests), including new cases asserting the assistant route opens dialog=files and / opens the global mobileTab=files. Verified in the running app at a 390px viewport: Files now opens the assistant workspace; / still opens the workspace root.

Summary by CodeRabbit

  • Bug Fixes
    • On assistant routes, selecting the Files tab now opens the repository Files dialog. On other routes, it continues to open the Files sheet.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 905cced3-998e-4615-bd4c-58815da725c5
📥 Commits

Reviewing files that changed from the base of the PR and between 0045a74 and e133d37.

📒 Files selected for processing (2)
  • frontend/src/components/navigation/MobileTabBar.test.tsx
  • frontend/src/components/navigation/MobileTabBar.tsx
 _________________________________________________
< Because, even your code needs a second opinion. >
 -------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chriswritescode-dev
chriswritescode-dev merged commit 704f818 into main Oct 7, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant