Repository navigation
fix(watch): preserve subdirectories in converted output - #82
Merged
chrisryugj merged 1 commit intoSep 24, 2026
Merged
Conversation
Recursive watching flattened all source paths to their basename, so alpha/report.hwpx and beta/report.hwpx silently overwrote the same output file. Preserve the relative parent directory and create it before writing. Add CLI integration coverage for Markdown and JSON with same-named documents in separate folders and a root-level document. Document the output layout. On Windows with Node 24, both new tests failed before the fix; the full offline suite now passes 2012 tests with 7 skips. Typecheck and build pass. Corpus and Hancom visual gates were not run.
chrisryugj
added a commit
that referenced
this pull request
Sep 24, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Owner
|
Thanks @ROTl24 — merged and included in v4.15.0.
Validation: Node 20/22/24 CI passed; local tests had 0 failures (2,295 passed, 3 skipped). The corpus gates passed, including 23,700 fuzz runs with no crashes, hangs or slow-limit failures. Both main and the v4.15.0 tag were successfully mirrored to GitLab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kordoc watch ./inbox -d ./convertedwatches recursively, but builds output paths frombasename(filePath). Ifinbox/alpha/report.hwpxandinbox/beta/report.hwpxarrive, both conversions succeed and writeconverted/report.md; one result silently overwrites the other. JSON output has the same problem.This keeps the relative parent directory, so the files become
converted/alpha/report.mdandconverted/beta/report.md. Root-level files keep their existing output paths. The README now describes this layout.The regression tests start the actual CLI watcher and convert generated HWPX documents in both output formats. Both tests failed before the change and pass afterward.
Validated on Windows, Node 24:
KORDOC_OFFLINE=1: 2012 passed, 7 skipped.npm run typecheckandnpm run build: passed.Corpus and Hancom visual gates were not run. This fixes collisions between subdirectories; same-stem files with different extensions in the same directory retain the existing naming behavior.