Skip to content

Add logging to Docker image retry#308

Merged
chrisguidry merged 1 commit intomainfrom
broader-docker-retry
Jan 26, 2026
Merged

Add logging to Docker image retry#308
chrisguidry merged 1 commit intomainfrom
broader-docker-retry

Conversation

@chrisguidry
Copy link
Owner

Summary

Adds print statements to the with_image_retry function so we can see in CI logs whether retries are happening and how many attempts before giving up.

This should help diagnose the intermittent ImageNotFound failures we're seeing in CI - we'll be able to tell if the retry logic is actually running or if there's something else going on.

🤖 Generated with Claude Code

Prints retry attempts to stdout so we can see in CI logs whether retries
are happening and how many before giving up.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@github-actions
Copy link

📚 Documentation has been built for this PR!

You can download the documentation directly here:
https://github.com/chrisguidry/docket/actions/runs/21363812602/artifacts/5258988334

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.61%. Comparing base (98ca355) to head (88af5eb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tests/_container.py 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
- Coverage   98.64%   98.61%   -0.03%     
==========================================
  Files          99       99              
  Lines        9903     9906       +3     
  Branches      483      483              
==========================================
  Hits         9769     9769              
- Misses        118      121       +3     
  Partials       16       16              
Flag Coverage Δ
python-3.10 98.61% <0.00%> (-0.03%) ⬇️
python-3.11 97.33% <0.00%> (-0.04%) ⬇️
python-3.12 98.61% <0.00%> (-0.03%) ⬇️
python-3.13 98.61% <0.00%> (-0.03%) ⬇️
python-3.14 98.60% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tests/_container.py 26.61% <0.00%> (-0.59%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrisguidry chrisguidry merged commit 8e06cdb into main Jan 26, 2026
72 of 73 checks passed
@chrisguidry chrisguidry deleted the broader-docker-retry branch January 26, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants