Skip to content

Move to pytest-asyncio to fix test failures for 3.14#174

Merged
desertaxle merged 18 commits intoclaude/support-python-310-011CUQFhrhzXGxLGyRjXk8k9from
fix-async-issues
Oct 25, 2025
Merged

Move to pytest-asyncio to fix test failures for 3.14#174
desertaxle merged 18 commits intoclaude/support-python-310-011CUQFhrhzXGxLGyRjXk8k9from
fix-async-issues

Conversation

@desertaxle
Copy link
Collaborator

No description provided.

Add tests for 3.14

Run `uv sync`

Remove extra file
@claude
Copy link
Contributor

claude bot commented Oct 24, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f6ec2c6) to head (a82972e).

Additional details and impacted files

Impacted file tree graph

@@                                 Coverage Diff                                  @@
##           claude/support-python-310-011CUQFhrhzXGxLGyRjXk8k9      #174   +/-   ##
====================================================================================
  Coverage                                              100.00%   100.00%           
====================================================================================
  Files                                                      33        33           
  Lines                                                    5103      5103           
  Branches                                                  263       263           
====================================================================================
  Hits                                                     5103      5103           
Flag Coverage Δ
python-3.10 84.81% <33.33%> (ø)
python-3.11 98.76% <100.00%> (ø)
python-3.12 100.00% <100.00%> (ø)
python-3.13 100.00% <100.00%> (ø)
python-3.14 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tests/cli/test_snapshot.py 100.00% <100.00%> (ø)
tests/cli/test_striking.py 100.00% <100.00%> (ø)
tests/test_fundamentals.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@desertaxle desertaxle changed the title Move to pytest-asyncio to fix test failures Move to pytest-asyncio to fix test failures for 3.14 Oct 24, 2025
@desertaxle desertaxle marked this pull request as ready for review October 24, 2025 21:06
Copy link
Owner

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You magnificent SOB. Okay one quick double-check, can we remove the --ignore tests/cli now????

# use a lower threshold to compensate
- python-version: "3.10"
cov-threshold: 75
pytest-ignore: "--ignore tests/cli"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@desertaxle could this possibly just work now without hanging? OMG

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately that is still an issue ☹️

@desertaxle desertaxle merged commit 8ad4f01 into claude/support-python-310-011CUQFhrhzXGxLGyRjXk8k9 Oct 25, 2025
21 of 22 checks passed
@desertaxle desertaxle deleted the fix-async-issues branch October 25, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants