DNS timeout: validate that c-Ares returns a success code

chrisgoffinet · chrisgoffinet · commit 950c734033da · 2020-02-04T13:53:47.000-05:00
we weren't checking the status returned from c-ares in cases such as timeouts
This is to prevent pushing an empty array list in the event
that a DNS timeout occurs
diff --git a/source/common/network/dns_impl.cc b/source/common/network/dns_impl.cc
@@ -127,7 +127,7 @@ void DnsResolverImpl::PendingResolution::onAresGetAddrInfoCallback(int status, i
   }
 
   if (completed_) {
-    if (!cancelled_) {
+    if (!cancelled_ && status == ARES_SUCCESS) {
       try {
         callback_(std::move(address_list));
       } catch (const EnvoyException& e) {

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ void DnsResolverImpl::PendingResolution::onAresGetAddrInfoCallback(int status, i`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`if (completed_) {`
`130`		`- if (!cancelled_) {`
	`130`	`+ if (!cancelled_ && status == ARES_SUCCESS) {`
`131`	`131`	`try {`
`132`	`132`	`callback_(std::move(address_list));`
`133`	`133`	`} catch (const EnvoyException& e) {`